Vulnerable to user-interface redressing (e.g. clickjacking)

Bug #1298784 reported by Julian Edwards on 2014-03-28
258
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
High
Julian Edwards
1.5
High
Julian Edwards
maas (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Unassigned

Bug Description

[Test Case]
Without the fix:
  1. Install MAAS.
  2. Create web page on other domain that loads MAAS in an IFRAME.
  3. MAAS loads and is usable.

With the fix:
  3. MAAS should not display, or should break out of the IFRAME.

Impact:
  A remote attacker could trick users into performing unintended actions
  within the application.

Commentary:
  The MAAS application has no protection against user-interface
  redressing attacks like clickjacking. By displaying the application in
  carefully constructed iframes on an unrelated domain, an attacker may
  be able to deceive users into performing one or two-click actions in
  the context of the application, such as deploying a charm. The impact
  of a successful clickjacking attack is similar to that of cross-site
  request forgery. See http://www.sectheory.com/clickjacking.htm for a
  worked demonstration of a clickjacking attack.

Exploitability:
  An attacker can only create exploits for forms that he would be able
  to view, as he would need to know the URL and positioning of the
  target forms. The attacker would also have to persuade a logged- in
  user to visit and click once or twice on the page under his control.
  A well-executed clickjacking attack is likely to go unnoticed by its
  victims.

Remediation:
  The application should instruct browsers not to allow other websites
  to load it in a frame, by adding the X-Frame-Options: SAMEORIGIN
  server header.

Related branches

tags: added: trivial
Raphaël Badin (rvb) wrote :

Fixing this bug should be as simple as enabling a middleware; see https://docs.djangoproject.com/en/dev/ref/clickjacking/.

information type: Private Security → Public Security
Changed in maas:
assignee: nobody → Julian Edwards (julian-edwards)
status: Triaged → In Progress
Changed in maas:
status: In Progress → Fix Committed
Gavin Panella (allenap) on 2014-05-08
description: updated
Changed in maas:
status: Fix Committed → Fix Released
Chris J Arges (arges) on 2014-05-09
Changed in maas (Ubuntu):
status: New → Fix Released

Hello Julian, or anyone else affected,

Accepted maas into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/maas/1.5.1+bzr2269-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in maas (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package maas - 1.5.1+bzr2269-0ubuntu0.1

---------------
maas (1.5.1+bzr2269-0ubuntu0.1) trusty; urgency=medium

  * Stable Release Update (LP: #1317601):
    - Hardware Enablement for Cisco B-Series. (LP: #1300476)
    - Allow AMT power type to specify IP Address. (LP: #1308772)
    - Spurious failure when starting and creating lock files. (LP: 1308069)
    - Fix usage of hardware enablement kernels by fixing the preseeds
      (LP: #1310082, LP: #1310076, LP: #1310082)
    - Fix parallel juju deployments. (LP: #1314409)
    - Clear distro_series when stopping node from WebUI (LP: #1316396)
    - Fix click hijacking (LP: #1298784)
    - Fix blocking API client when deleting a resource (LP: #1313556)
    - Do not import Trusty RC images by default (LP: #1311151)
    - debian/control: Add missing dep on python-crochet for
      python-maas-provisioningserver (LP: #1311765)
 -- Andres Rodriguez <email address hidden> Fri, 09 May 2014 22:35:43 -0500

Changed in maas (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for maas has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public Security information  Edit
Everyone can see this security related information.

Other bug subscribers