When any of the commissioning scripts fails, the error reported contains the list of the scripts that *didn't* fail
Bug #1278895 reported by
Raphaël Badin
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Raphaël Badin |
Bug Description
I managed to make the commissioning phase fail by shutting off the internet connection of my nodes. Instead of mentioning the scripts that need internet access to run (and thus failed), the error displayed on the node page gave a list of the scripts that didn't fail: "failed [2/5] ( 00-maas-01-lshw 00-maas-
Related branches
lp:~rvb/maas/fix-signal-reporting
- Jeroen T. Vermeulen (community): Approve
-
Diff: 42 lines (+9/-8)1 file modifiedetc/maas/templates/commissioning-user-data/user_data.template (+9/-8)
Changed in maas: | |
importance: | High → Critical |
summary: |
- When any of commissioning scripts fails, the error reported contains the - list of the scripts that *didn't* fail + When any of the commissioning scripts fails, the error reported contains + the list of the scripts that *didn't* fail |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I tested the fix for this and MAAS is now working as expected. As an example, this is the error message displayed after a failed commissioning phase (failed because the node couldn't reach the internet to download packages): "failed [3/5] (00-maas- 03-install- lldpd, 99-maas- 01-wait- for-lldpd, 99-maas- 02-capture- lldp)". Of course, I also tested the happy code path where commissioning succeeds.