'maas createsuperuser' errors out if no email address is entered.

[Patricia Gaughen]

Was getting MAAS setup on my system, just to play with it, and didn't enter an email address. The tool didn't complain about leaving the email address blank, but when the the tool exited the superuser wasn't created and an error message was displayed.

Here is the output (and yes, I tried to leave the password blank too.. but note the command complained about leaving it blank)

gaughen@glitter:~$ sudo maas createsuperuser
Username (leave blank to use 'root'): maas_admin
Email address:
Password:
Password (again):
Error: Blank passwords aren't allowed.
Password:
Password (again):
IntegrityError: duplicate key value violates unique constraint "auth_user_email_key"
DETAIL: Key (email)=() already exists.

I think the correct behavior, if the email address is truly required, is to produce an error message similar to when you try to leave the password blank.

[Jeroen T. Vermeulen (jtv)]

For the historical record:

 * createsuperuser is a Django built-in command, not our code.
 * We have our own MAAS-tailored version, createadmin.
 * The email field must be unique and non-null, but can be empty.
 * MAAS already creates a system user with empty email address.
 * A null email address would be the right way to do this, but Django's supports null values more or less as an afterthought.

The simple fix is to update the documentation, so it always points users to createadmin, not createsuperuser.

[Gavin Panella (allenap)]

Can we create our own wrapper around django-admin (here spelled "maas") that only exposes the commands directly relevant to MAAS. We could have a maas-django-admin too, for people who want to shoot at their feet.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.