Commissioning user_data does not check for all errors
Bug #1239668 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Unassigned | ||
Bug Description
etc/maas/
maas-get --config=
could fail. However, the script would then continue and signal success - marking the node as having passed commissioning - because there are no commissioning script to run!
Related branches
lp:~julian-edwards/maas/commissioning_error_check_bug_1239668
- Gavin Panella (community): Disapprove
-
Diff: 14 lines (+4/-0)1 file modifiedetc/maas/templates/commissioning-user-data/user_data.template (+4/-0)
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| tags: | added: trivial |
| Changed in maas: | |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| status: | Triaged → In Progress |
| milestone: | none → 13.10 |
| Changed in maas: | |
| milestone: | 13.10 → 14.04 |
| Changed in maas: | |
| status: | In Progress → Triaged |
| assignee: | Julian Edwards (julian-edwards) → nobody |
| tags: | removed: trivial |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
| Changed in maas: | |
| importance: | Critical → High |
| Changed in maas: | |
| milestone: | 14.04 → 14.10 |
| Changed in maas: | |
| milestone: | 1.6.0 → none |
| Changed in maas: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
The merge proposal comments attached to this bug explain why the shell script in user_data.template is such an awful hideous mess that it needs a total re-write, with unit tests.
Therefore I am going to downgrade this from critical, to reflect the nature of its urgency. What is there works for now.