maas-import-ephemerals deletes only with --delete
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Unassigned |
Bug Description
The current simplestreams based maas-import-
This is reasonable to an extent, but it makes '--max' basically worthless.
simplestreams 'sync' has 2 variables to control this:
a.) 'max' is an integer value. If provided to the mirror, it will only keep the lastest MAX versions that are being mirrored. If unset, it will mirror all versions available.
b.) 'keep' is a boolean value. If keep is true (default is false) and max is set to a value larger than the number of versions available, it will keep versions found locally that are not found remotely. If 'keep' is false then local versions older than remote versions will be deleted.
The implementation we have right now is just to not delete unless '--delete' is provided. I think the default behavior of sstreams is probably correct or at least acceptable. Let the user specify a 'max' (likely 1 or 2), and let deletes happen as they would.
We do want to make sure that new products that are not found in the remote are not deleted. Ie, if '12.10:
Changed in maas: | |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Seems like --max and --keep imply --delete, excepting local-only files.