bug in commissioning-user-data means power_settings always passed from commissioning

Bug #1103716 reported by Scott Moser
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Medium
Unassigned
1.2
Fix Released
Medium
Unassigned

Bug Description

/etc/maas/commissiong-user-data (and trunk src/metadataserver/commissioning/user_data.template) say:

   power_settings=$(maas-ipmi-autodetect --configdir "$IPMI_CONFIG_D" ${pargs})
   if [ ! -z "power_settings" ]; then
      signal "--power-type=ipmi" "--power-parameters=${power_settings}" WORKING "finished [maas-ipmi-autodetect]"
   fi

'power_settings' will never be empty, meaning the signal will always run.

the check for '-z' should be in '$power_settings'.

Related branches

Scott Moser (smoser)
Changed in maas:
status: New → Confirmed
status: Confirmed → Triaged
importance: Undecided → Medium
Changed in maas:
status: Triaged → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.