maas-import-pxe-files fails when run from trunk

Bug #1076409 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Critical
Gavin Panella
1.2
High
Gavin Panella
Trunk
Critical
Gavin Panella

Bug Description

From a checkout of maas trunk, if I run:

sudo http_proxy=http://<proxy>:3128/ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/home/ubuntu/maas/bin:/home/ubuntu/maas/scripts MAAS_PROVISIONING_SETTINGS=/home/ubuntu/maas/etc/pserv.yaml scripts/maas-import-pxe-files

then I get the error:

/home/ubuntu/maas/scripts/maas-import-squashfs: line 47: RELEASES: unbound variable

This happens because maas-import-squashfs sets "set -o nounset" but then uses a '[ -z "$RELEASES" ]' test on line 47.

Workaround (and possibly a proper fix) is to change the test on line 47 to '[ -z "${RELEASES:-}" ]'. Though this then led me to bug 1074167.

Related branches

Robie Basak (racb)
tags: added: tech-debt velocity
description: updated
Revision history for this message
Robie Basak (racb) wrote :

Here's a script that reproduces the problem on a fresh Quantal install (enable multiverse first).

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Given that squashfs images don't really help the node installation time very much (and server team is working on something else), I'm tempted to just remove this part of the import entirely since it has caused a few bugs now.

Changed in maas:
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Julian Edwards (julian-edwards) wrote :

And now bug 1077180

I am going to remove squashfs support, there's too many bugs.

Gavin Panella (allenap)
Changed in maas:
status: Triaged → In Progress
assignee: nobody → Gavin Panella (allenap)
Changed in maas:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments