duplicate entry added to named.conf.local on each package reconfigure
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Undecided
|
Unassigned | ||
1.2 |
Fix Released
|
Critical
|
Julian Edwards | ||
maas (Ubuntu) |
Fix Released
|
Undecided
|
Gavin Panella | ||
Precise |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Running dpkg-reconfigure maas-dns breaks the current dns config
Observation seems to indicate that each reconfigure appends the following line to /etc/bind/
include "/etc/bind/
This causes bind to choke and output confusing messages about multiple definitions of the master zone
ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: maas-dns 0.1+bzr1264+
ProcVersionSign
Uname: Linux 3.5.0-17-generic i686
ApportVersion: 2.6.1-0ubuntu3
Architecture: i386
Date: Mon Oct 15 17:04:52 2012
InstallationMedia: Ubuntu-Server 12.10 "Quantal Quetzal" - Release i386 (20121014)
PackageArchitec
ProcEnviron:
LANGUAGE=en_US:en
TERM=xterm-
PATH=(custom, no user)
LANG=en_US.UTF-8
SHELL=/bin/bash
SourcePackage: maas
UpgradeStatus: No upgrade log present (probably fresh install)
== TEST CASE ==
1. Install MAAS with DNS server.
2. dpkg-reconfigure maas-dns
3. make sure line is not duplicationed in /etc/bind/
Tested in the lenovo lab. Runnning "dpkg-reconfigure maas-dns" does not append the same include line over and over.
Related branches
- Raphaël Badin (community): Approve
-
Diff: 20 lines (+4/-6)1 file modifieddebian/maas-dns.postinst (+4/-6)
- Raphaël Badin (community): Approve
-
Diff: 41 lines (+5/-4)3 files modifiedsrc/maasserver/management/commands/get_named_conf.py (+2/-2)
src/provisioningserver/dns/config.py (+2/-1)
src/provisioningserver/dns/tests/test_config.py (+1/-1)
- Andres Rodriguez (community): Approve
- Raphaël Badin (community): Approve
-
Diff: 12 lines (+3/-1)1 file modifieddebian/changelog (+3/-1)
- Julian Edwards (community): Approve
-
Diff: 41 lines (+5/-4)3 files modifiedsrc/maasserver/management/commands/get_named_conf.py (+2/-2)
src/provisioningserver/dns/config.py (+2/-1)
src/provisioningserver/dns/tests/test_config.py (+1/-1)
Changed in maas (Ubuntu): | |
assignee: | nobody → Gavin Panella (allenap) |
status: | New → In Progress |
Changed in maas (Ubuntu): | |
status: | In Progress → Fix Committed |
tags: | added: sru-12.10 |
Changed in maas (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in maas (Ubuntu): | |
status: | Fix Released → Fix Committed |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
description: | updated |
Changed in maas (Ubuntu Precise): | |
status: | New → Fix Released |
Changed in maas: | |
status: | New → Fix Released |
no longer affects: | maas/1.2 |
no longer affects: | maas |
Changed in maas: | |
status: | New → Fix Released |
I see two ways to fix this: named.conf. local if it's already there config_ section (src/provisioni ngserver/ utils.py) but I wonder if we can manage the upgrade properly.
- we can fix this in the packaging and avoid adding the entry in /etc/bind/
or
- we can fix the 'get_named_conf' command so that it won't include the snippet if it's already there. Maybe we could use write_custom_