Node listing page becomes unusable with increased number of nodes
Bug #1064672 reported by
Francis J. Lacoste
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Martin Packman | ||
maas (Ubuntu) |
Fix Released
|
High
|
Andres Rodriguez | ||
Precise |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The nodes listing page displays all nodes enlisted in MAAS. As the number of nodes increase, that page becomes slower and slower to render and build.
We should add some pagination to make this at least minimally usable for large scale MAAS deployment.
== TEST CASE ==
This fix has been tested on both canonistack and in the lenovo lab.
1. Add various nodes to MAAS
2. See node listing pages
Tested in the lenovo lab. $ while true; do maas-cli maas nodes new architecture="i386" mac_addresses=
Hit ctrl+c after the command adds more than 50 nodes. See the the pagination.
Related branches
lp:~gz/maas/paginate_nodes_page_1064672
- John A Meinel (community): Approve
-
Diff: 370 lines (+250/-13)6 files modifiedsrc/maasserver/templates/maasserver/node_list.html (+2/-1)
src/maasserver/templates/maasserver/pagination.html (+19/-7)
src/maasserver/tests/test_views.py (+104/-1)
src/maasserver/tests/test_views_nodes.py (+58/-0)
src/maasserver/views/__init__.py (+62/-1)
src/maasserver/views/nodes.py (+5/-3)
lp:~andreserl/maas/packaging_bzr1269_quantal
- Julian Edwards (community): Approve
-
Diff: 60 lines (+23/-3)3 files modifieddebian/changelog (+21/-1)
debian/extras/maas-region-celeryd (+1/-1)
debian/rules (+1/-1)
Changed in maas: | |
assignee: | nobody → Martin Packman (gz) |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
tags: | added: sru-12.10 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Critical |
assignee: | nobody → Andres Rodriguez (andreserl) |
importance: | Critical → High |
description: | updated |
description: | updated |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
Changed in maas (Ubuntu Precise): | |
status: | New → Fix Released |
no longer affects: | maas/1.2 |
To post a comment you must log in.
Note that I just proposed a patch (nodes_perf) that changes the code so it doesn't do N lookup queries for N nodes.
I've tested with 10,000 nodes on the page, and while it was slow to load (5s) it still completed, vs failing with an OOPS after a couple of minutes without that change.
I agree that pagination is a good final place to be, but at least we can load pages with ~1000 nodes in a reasonable amount of time.