The expectations of MAASDispatcher.dispatch_query are not tested

Bug #1064437 reported by Gavin Panella
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MAAS
Won't Fix
High
Unassigned

Bug Description

The return value from dispatch_query is defined as:

  :return: A open file-like object that contains the response.

However, code that uses it depends on the fact that it's the return
value of urllib2.urlopen, which is a urllib.addinfourl instance, with
methods like getcode, info, and geturl.

The real problem is that none of this is tested, so a recent change to
use httplib2 instead of urllib2 passed the test suite with minimal
alterations, but broke start_cluster_controller.

Tags: tech-debt
Changed in maas:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.