Extra kernel opts are separated by ---, not -- in MAAS

Bug #1654853 reported by Marius Žalinauskas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
maas-images
Expired
Medium
Unassigned

Bug Description

compose_kernel_command_line() in maas/src/provisioningserver/kernel_opts.py clearly states that extra kernel options are separated by --- and not --.

As get_extra_kernel_parameters() in CentOS Curtin hooks use --, any extra kernel option MAAS passes does not get in to GRUB configuration.

Scott Moser (smoser)
Changed in maas-images:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Jacopo Rota (r00ta) wrote :

I see the comment states

```

def get_curtin_kernel_cmdline_sep():
    """Return the separator for passing extra parameters to the kernel."""
    return getattr(
        curtin, CURTIN_KERNEL_CMDLINE_NAME, '--')

...
...
    cmdline_sep = get_curtin_kernel_cmdline_sep()
    if params.extra_opts:
        # Using --- before extra opts makes both d-i and Curtin install
        # them into the grub config when installing an OS, thus causing
        # the options to "stick" when local booting later.
        # see LP: #1402042 for info on '---' versus '--'
```

We should be good. Feel free to reopen in case I misunderstood this bug

Changed in maas-images:
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for maas-images because there has been no activity for 60 days.]

Changed in maas-images:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.