3.7.2 failed tests

[bharper]

Start with 3.7.2 two tests are failing:

======================================================================
FAIL: test_attribute_quoting_unicode (lxml.tests.test_incremental_xmlfile.HtmlFileTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib64/python3.5/unittest/case.py", line 638, in run
    testMethod()
  File "/builddir/build/BUILD/lxml-3.7.2/src/lxml/tests/test_incremental_xmlfile.py", line 434, in test_attribute_quoti
ng_unicode
    self.assertXml('<tagname attr="&quot;misqu&#246;ted&#13124;&#78660;&quot;">foo</tagname>')
  File "/builddir/build/BUILD/lxml-3.7.2/src/lxml/tests/test_incremental_xmlfile.py", line 270, in assertXml
    self.assertEqual(self._read_file().decode(encoding), expected)
  File "/usr/lib64/python3.5/unittest/case.py", line 858, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib64/python3.5/unittest/case.py", line 1231, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/usr/lib64/python3.5/unittest/case.py", line 703, in fail
    raise self.failureException(msg)
AssertionError: '<tagname attr="&quot;misqu&#246;ted\\u3344\\U00013344&quot;">foo</tagname>' != '<tagname attr="&quot;m
isqu&#246;ted&#13124;&#78660;&quot;">foo</tagname>'
- <tagname attr="&quot;misqu&#246;ted\u3344\U00013344&quot;">foo</tagname>
? ^^^^^^^^^^^ ^ ^
+ <tagname attr="&quot;misqu&#246;ted&#13124;&#78660;&quot;">foo</tagname>
? ^^ ^^ ^^^^^^^^^
======================================================================
FAIL: test_unescaped_script_incremental (lxml.tests.test_incremental_xmlfile.HtmlFileTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib64/python3.5/unittest/case.py", line 638, in run
    testMethod()
  File "/builddir/build/BUILD/lxml-3.7.2/src/lxml/tests/test_incremental_xmlfile.py", line 448, in test_unescaped_script_incremental
    self.assertXml('<script>if (a < b);</script>')
  File "/builddir/build/BUILD/lxml-3.7.2/src/lxml/tests/test_incremental_xmlfile.py", line 270, in assertXml
    self.assertEqual(self._read_file().decode(encoding), expected)
  File "/usr/lib64/python3.5/unittest/case.py", line 858, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib64/python3.5/unittest/case.py", line 1231, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/usr/lib64/python3.5/unittest/case.py", line 703, in fail
    raise self.failureException(msg)
AssertionError: '<script>if (a &lt; b);</script>' != '<script>if (a < b);</script>'
- <script>if (a &lt; b);</script>
? ^^^^
+ <script>if (a < b);</script>
?
...
TESTED VERSION: 3.7.2
    Python: sys.version_info(major=3, minor=5, micro=2, releaselevel='final', serial=0)
    lxml.etree: (3, 7, 2, 0)
    libxml used: (2, 9, 1)
    libxml compiled: (2, 9, 1)
    libxslt used: (1, 1, 28)
    libxslt compiled: (1, 1, 28)

These two failed tests appear to be related to the following changes in 3.7.2:

https://github.com/lxml/lxml/pull/218
https://github.com/lxml/lxml/pull/219

[scoder (scoder)]

Should be fixed in 3.7.3. Please reopen if this is still an issue.

[Thomas Klausner (tk-giga)]

I just tested 3.8.0 and these problems are indeed gone, thanks.