test_cache failed on lxml 3.4.3

Bug #1444818 reported by Felix Yan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxml
Fix Released
Low
scoder

Bug Description

lxml 3.4.2 was passing all the tests for me, but one test (test_cache) failed on 3.4.3:

======================================================================
FAIL: test_cache (lxml.tests.test_elementpath.ElementTreeElementPathTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.4/unittest/case.py", line 58, in testPartExecutor
    yield
  File "/usr/lib/python3.4/unittest/case.py", line 577, in run
    testMethod()
  File "/build/python-lxml/src/lxml-3.4.3/src/lxml/tests/test_elementpath.py", line 27, in test_cache
    self.assertEqual(2, len(self._elementpath._cache))
  File "/usr/lib/python3.4/unittest/case.py", line 797, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.4/unittest/case.py", line 790, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 2 != 1

----------------------------------------------------------------------
Ran 1657 tests in 10.202s

FAILED (failures=1)
Comparing with ElementTree 1.3.0

TESTED VERSION: 3.4.3
    Python: sys.version_info(major=3, minor=4, micro=3, releaselevel='final', serial=0)
    lxml.etree: (3, 4, 3, 0)
    libxml used: (2, 9, 2)
    libxml compiled: (2, 9, 2)
    libxslt used: (1, 1, 28)
    libxslt compiled: (1, 1, 28)

Makefile:33: recipe for target 'test_inplace' failed
make: *** [test_inplace] Error 1

Revision history for this message
scoder (scoder) wrote :

Yes, sorry. I only noticed this after the release. It's entirely irrelevant, though, as the test actually uses ElementTree and not lxml. So there's nothing wrong in lxml here, only the test itself. I'll eventually fix it in the next release (and it's already disabled in the latest 3.4 branch).

Changed in lxml:
assignee: nobody → scoder (scoder)
importance: Undecided → Low
milestone: none → 3.4
status: New → Confirmed
Revision history for this message
Felix Yan (felixonmars) wrote :

I see, so I'll allow the test to fail and package this version as usual for Arch.

Thanks for the info!

Revision history for this message
scoder (scoder) wrote :

You can apply this patch if you want, but I guess there'll be a vacuous fix release in a couple of days or so.

https://github.com/lxml/lxml/commit/99547dd5660279bdfc3663cfdecb260796105992

scoder (scoder)
Changed in lxml:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers