(HTML) class manipulation shortcuts

[Xavier (Open ERP)]

lxml.html adds a number of shortcuts for manipulating HTML trees http://lxml.de/lxmlhtml.html#html-element-methods

A useful one would be the ability to more easily set and unset classes on elements, e.g. provide a `set`-like interface to the `class` html attribute, possibly extended with a classList-type `toggle(token[, force])`[0] method: although this is probably less fraught with risks than in javascript, class interaction through the string value is not exactly fun.

[0] http://dom.spec.whatwg.org/#dom-domtokenlist-toggle

[scoder (scoder)]

Agreed, would be nice to have.

[scoder (scoder)]

I think a nice interface would be an attribute "classes" that provides methods "add()" and "remove()".

[Xavier (Open ERP) (xmo-deactivatedaccount)]

A "contains" operation is also relatively frequent. collections.MutableSet seems to fit the bill rather well.

[scoder (scoder)]

Absolutely. I take pull requests.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

A few questions:

* the website (lxml.de) claims 2.6+ compatibility, but reading lxml.html there's a bunch of compatibility shims for as low as Python 2.3. Which is it? Should I remove the pre-2.6 stuff from lxml.html or should I ensure my addition is 2.3-compatible?
* PRs are on github?

[scoder (scoder)]

Yes, PRs should go to github. The pre-2.6 stuff is pure legacy and just hasn't been removed yet. Since version 3.4 (i.e. fairly recently), lxml supports 2.6+ only. If you care to take the time for removing dead code, I'll happily accept a PR for it, too.

[scoder (scoder)]

Implemented here:
https://github.com/lxml/lxml/commit/453a4203187e6552359f4ba94a2dee8cc6b93a92

[scoder (scoder)]

Implemented in lxml 3.5.0.