2.13.0 FTBFS

[Andreas Hasenack]

I tried to merge ust from debian into ubuntu, to fix a build-time dependency, but stumbled on an FTBFS with that version.

I filed upstream bug at https://bugs.lttng.org/issues/1337

It basically happens in some new test cases that were added in 2.13.0 and crash when we build it using our default -Wl,-Bsymbolic-flags linker option, which we have been using for years in Ubuntu.

Here is the testsuite log output:
================================================
   lttng-ust 2.14.0-pre: tests/test-suite.log
================================================

# TOTAL: 246
# PASS: 241
# SKIP: 0
# XFAIL: 0
# FAIL: 4
# XPASS: 0
# ERROR: 1

.. contents:: :depth: 2

ERROR: regression/abi0-conflict/test_abi0_conflict
==================================================

1..22
# LD_PRELOAD
# regression/abi0-conflict/test_abi0_conflict: LD_PRELOAD
ok 1 - LD_PRELOAD: no-ust app works
PASS: regression/abi0-conflict/test_abi0_conflict 1 - LD_PRELOAD: no-ust app works
ok 2 - LD_PRELOAD: no-ust app with abi0 preload succeeds
PASS: regression/abi0-conflict/test_abi0_conflict 2 - LD_PRELOAD: no-ust app with abi0 preload succeeds
./regression/abi0-conflict/test_abi0_conflict: line 56: 592651 Aborted (core dumped) LD_PRELOAD="${LIBFAKEUST0}:${LIBUST1}" "${CURDIR}/app_noust" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 3 - LD_PRELOAD: no-ust app with abi0 and abi1 preload fails
PASS: regression/abi0-conflict/test_abi0_conflict 3 - LD_PRELOAD: no-ust app with abi0 and abi1 preload fails
./regression/abi0-conflict/test_abi0_conflict: line 59: 592652 Aborted (core dumped) LD_PRELOAD="${LIBUST1}:${LIBFAKEUST0}" "${CURDIR}/app_noust" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 4 - LD_PRELOAD: no-ust app with abi1 and abi0 preload fails
PASS: regression/abi0-conflict/test_abi0_conflict 4 - LD_PRELOAD: no-ust app with abi1 and abi0 preload fails
ok 5 - LD_PRELOAD: ust app works
PASS: regression/abi0-conflict/test_abi0_conflict 5 - LD_PRELOAD: ust app works
./regression/abi0-conflict/test_abi0_conflict: line 68: 592669 Aborted (core dumped) LD_PRELOAD="${LIBFAKEUST0}" "${CURDIR}/app_ust" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 6 - LD_PRELOAD: ust app with abi0 preload fails
PASS: regression/abi0-conflict/test_abi0_conflict 6 - LD_PRELOAD: ust app with abi0 preload fails
./regression/abi0-conflict/test_abi0_conflict: line 71: 592683 Aborted (core dumped) LD_PRELOAD="${LIBFAKEUST0}:${LIBUST1}" "${CURDIR}/app_ust" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 7 - LD_PRELOAD: ust app with abi0 and abi1 preload fails
PASS: regression/abi0-conflict/test_abi0_conflict 7 - LD_PRELOAD: ust app with abi0 and abi1 preload fails
./regression/abi0-conflict/test_abi0_conflict: line 74: 592684 Aborted (core dumped) LD_PRELOAD="${LIBUST1}:${LIBFAKEUST0}" "${CURDIR}/app_ust" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 8 - LD_PRELOAD: ust app with abi1 and abi0 preload fails
PASS: regression/abi0-conflict/test_abi0_conflict 8 - LD_PRELOAD: ust app with abi1 and abi0 preload fails
# dlopen
# regression/abi0-conflict/test_abi0_conflict: dlopen
ok 9 - dlopen: no-ust app works
PASS: regression/abi0-conflict/test_abi0_conflict 9 - dlopen: no-ust app works
ok 10 - dlopen: no-ust app with abi1 and abi1 succeeds
PASS: regression/abi0-conflict/test_abi0_conflict 10 - dlopen: no-ust app with abi1 and abi1 succeeds
./regression/abi0-conflict/test_abi0_conflict: line 92: 592689 Aborted (core dumped) LD_LIBRARY_PATH="$LIBFAKEUST0_PATH:$LIBUST1_PATH" "${CURDIR}/app_noust_dlopen" abi0_abi1 > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 11 - dlopen: no-ust app with abi0 and abi1 fails
PASS: regression/abi0-conflict/test_abi0_conflict 11 - dlopen: no-ust app with abi0 and abi1 fails
not ok 12 - dlopen: no-ust app with abi1 and abi0 fails
FAIL: regression/abi0-conflict/test_abi0_conflict 12 - dlopen: no-ust app with abi1 and abi0 fails
# Failed test 'dlopen: no-ust app with abi1 and abi0 fails'
# regression/abi0-conflict/test_abi0_conflict: Failed test 'dlopen: no-ust app with abi1 and abi0 fails'
# in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# regression/abi0-conflict/test_abi0_conflict: in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# got: '0'
# regression/abi0-conflict/test_abi0_conflict: got: '0'
# expected: '0'
# regression/abi0-conflict/test_abi0_conflict: expected: '0'
ok 13 - dlopen: ust app works
PASS: regression/abi0-conflict/test_abi0_conflict 13 - dlopen: ust app works
not ok 14 - dlopen: ust app with abi0 fails
FAIL: regression/abi0-conflict/test_abi0_conflict 14 - dlopen: ust app with abi0 fails
# Failed test 'dlopen: ust app with abi0 fails'
# regression/abi0-conflict/test_abi0_conflict: Failed test 'dlopen: ust app with abi0 fails'
# in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# regression/abi0-conflict/test_abi0_conflict: in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# got: '0'
# regression/abi0-conflict/test_abi0_conflict: got: '0'
# expected: '0'
# regression/abi0-conflict/test_abi0_conflict: expected: '0'
not ok 15 - dlopen: ust app with abi0 and abi1 fails
FAIL: regression/abi0-conflict/test_abi0_conflict 15 - dlopen: ust app with abi0 and abi1 fails
# Failed test 'dlopen: ust app with abi0 and abi1 fails'
# regression/abi0-conflict/test_abi0_conflict: Failed test 'dlopen: ust app with abi0 and abi1 fails'
# in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# regression/abi0-conflict/test_abi0_conflict: in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# got: '0'
# regression/abi0-conflict/test_abi0_conflict: got: '0'
# expected: '0'
# regression/abi0-conflict/test_abi0_conflict: expected: '0'
not ok 16 - dlopen: ust app with abi1 and abi0 fails
FAIL: regression/abi0-conflict/test_abi0_conflict 16 - dlopen: ust app with abi1 and abi0 fails
# Failed test 'dlopen: ust app with abi1 and abi0 fails'
# regression/abi0-conflict/test_abi0_conflict: Failed test 'dlopen: ust app with abi1 and abi0 fails'
# in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# regression/abi0-conflict/test_abi0_conflict: in /home/ubuntu/git/packages/ust/lttng-ust/tests/utils/tap.sh:isnt() at line 300.
# got: '0'
# regression/abi0-conflict/test_abi0_conflict: got: '0'
# expected: '0'
# regression/abi0-conflict/test_abi0_conflict: expected: '0'
# Indirect linking
# regression/abi0-conflict/test_abi0_conflict: Indirect linking
ok 17 - indirect: no-ust app with abi0 succeeds
PASS: regression/abi0-conflict/test_abi0_conflict 17 - indirect: no-ust app with abi0 succeeds
ok 18 - indirect: no-ust app with abi1 succeeds
PASS: regression/abi0-conflict/test_abi0_conflict 18 - indirect: no-ust app with abi1 succeeds
./regression/abi0-conflict/test_abi0_conflict: line 131: 592803 Aborted (core dumped) "${CURDIR}/app_noust_indirect_abi0_abi1" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 19 - indirect: no-ust app with abi0 and abi1 fails
PASS: regression/abi0-conflict/test_abi0_conflict 19 - indirect: no-ust app with abi0 and abi1 fails
./regression/abi0-conflict/test_abi0_conflict: line 136: 592817 Aborted (core dumped) "${CURDIR}/app_ust_indirect_abi0" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 20 - indirect: ust app with abi0 fails
PASS: regression/abi0-conflict/test_abi0_conflict 20 - indirect: ust app with abi0 fails
ok 21 - indirect: ust app with abi1 succeeds
PASS: regression/abi0-conflict/test_abi0_conflict 21 - indirect: ust app with abi1 succeeds
./regression/abi0-conflict/test_abi0_conflict: line 142: 592847 Aborted (core dumped) "${CURDIR}/app_ust_indirect_abi0_abi1" > "$STD_OUTPUT" 2> "$STD_ERROR"
ok 22 - indirect: ust app with abi0 and abi1 fails
PASS: regression/abi0-conflict/test_abi0_conflict 22 - indirect: ust app with abi0 and abi1 fails
# Looks like you failed 4 tests of 22.
# regression/abi0-conflict/test_abi0_conflict: Looks like you failed 4 tests of 22.
ERROR: regression/abi0-conflict/test_abi0_conflict - exited with status 4

[Andreas Hasenack (ahasenack)]

Fix was merged usptream, and 2.13.1 contains it.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ust - 2.13.1-1ubuntu1

---------------
ust (2.13.1-1ubuntu1) jammy; urgency=medium

  * Merge with Debian unstable. Remaining changes:
    - d/liblttng-ust-python-agent1.symbols, d/liblttng-ust1.symbols: Mark
      symbols as optional not seen when building with lto.
  * Added changes:
    - d/rules: set UST_TESTS_LD_SYMBOLIC_FUNC during the test run to skip
      tests that do not work with the -Wl,-Bsymbolic-functions linker
      option (LP: #1953065)

 -- Andreas Hasenack <email address hidden> Wed, 22 Dec 2021 19:46:51 -0300

[Andreas Hasenack (ahasenack)]

I sent this delta to debian for consideration.

https://salsa.debian.org/debian/ust/-/merge_requests/5