ldm login and password that starts with '@'

Bug #948507 reported by Norman Gaywood on 2012-03-06
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
LTSP5
Undecided
Unassigned

Bug Description

When at the ldm login screen, if you type @ as the first
character of the password, the enter key does not work.

The password of @guest@ or @backend@ will allow the enter key to work
again but the login screen will just go back to the user prompt.

This of course will stop people having @ as the first character of their
password.

Todd O'Bryan (toddobryan-gmail) wrote :

I'm not sure, but I think an @ character anywhere in the password causes the same problem (i.e., that you can't hit the enter key). It seems like @ is being used as some kind of escape key, but that could be very confusing.

Stéphane Graber (stgraber) wrote :

I just pushed the change below to the code, I believe it'll fix your problem.

=== modified file 'src/ldmgreetercomm.c'
--- src/ldmgreetercomm.c 2011-11-02 15:18:14 +0000
+++ src/ldmgreetercomm.c 2012-03-29 13:55:06 +0000
@@ -132,10 +132,11 @@
         if (**buffer == '@') {
             if (!g_strncasecmp(*buffer, "@backend@", 9)) {
                 ldm_raise_auth_except(AUTH_EXC_RELOAD_BACKEND);
+ continue;
             } else if (!g_strncasecmp(*buffer, "@guest@", 7)) {
                 ldm_raise_auth_except(AUTH_EXC_GUEST);
+ continue;
             }
- continue;
         }
         break;
     }

Changed in ltsp:
status: New → Fix Committed
Changed in ltsp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers