No saving dialog on exit

[Raffaella Traniello]

Usability bug:
Stopmotion allows you to exit an unsaved project and lose your work.

A saving dialog should pop up and invite the user to save the unsaved project before exiting.

[Minaya Serrano (minayaserrano)]

Added the saving dialog when user close stopmotion with "Alt-F4" or "close window".

Use 'patch -p 1 < bug863965_save_on_exit.patch' inside linuxstopmotion-code directory to apply it.

IMPORTANT: This patch must be apply AFTER "bug1045552_include_unistd.patch" because it affects the same file.

[Minaya Serrano (minayaserrano)]

I fixed this bug on:
http://sourceforge.net/u/minayaserrano/linuxstopmotion/ci/42011b954ed80cb09f964397b3e26bad2cc755e3/

I'll generate the patch and the merge request when the debian misc tweaks are merged on master to avoid errors.

[Raffaella Traniello (raffaella-traniello)]

I tested the fix in my Ubuntu 12.10 32-bit GNOME 3.6.0
The dialogue does appear when I quit an unsaved project from the menu File->Quit or with the shortcut CTRL+Q.
But I found the following issues:

1. The dialogue doesn't appear when I close LSM with the window cross "X", nor if I close it with ALT+F4.

2. When the dialogue is open If I choose SAVE but then I change my mind and instead of saving I choose CANCEL, then LSM closes without saving my project. I would expect only the saving dialogue to close, not LSM

[Minaya Serrano (minayaserrano)]

Hi Raffaella!

It's weird because this two problems are the two problems this patch resolves ;-) It works on my ubuntu 12.10 64-bit. Maybe the patch was't applied or you are running the global system instance of stopmotion without patch?

You must apply the patch and compiles it:

$ patch -p 1 < bug863965_save_on_exit.patch
$ make
$ ./stopmotion

If it doesn't work yet, could you test it on a fresh directory?

$ git clone git://git.code.sf.net/u/minayaserrano/linuxstopmotion -b bug863965-save-on-exit linuxstopmotiontest
$ cd linuxstopmotiontest
$ qmake stopmotion.pro
$ make
$ ./stopmotion

Un Saludo de
Minaya

[Raffaella Traniello (raffaella-traniello)]

Sorry, I was testing the wrong code.

My test report is now:

The dialogue now appears when I close stopmotion with all 4 methods.
- from the mwnu File -> Quit.
- with CTRL+Q
- with the X of the window
- with ALT+F4

Still an issue remains:
If click on SAVE in the Unsaved Changes dialogue, I open the saving
dialogue. That saving dialogue has a CANCEL and a SAVE button.
If I click on CANCEL LSM will close.

Not sure if it is a close or a crash.
If I open the saving dialogue from the menu File->Save a click on CANCEL
will cancel the saving operation, leaving LSM open.

[Tim Band (tim-band)]

There's still no dialog, but now it doesn't matter because restore actually works and is automatic.

[Tim Band (tim-band)]

released in 0.8.0