Xenial: could not find a lxd remote image

[Nathan Teodosio]

When adding xenial to Launchpad CI:

--->
Launching environment for xenial/amd64
could not find a lxd remote image for the provider base <craft_providers.bases.ubuntu.BuilddBase object at 0x7f4491d92ac0>
<---

The problem does not exist in bionic, jammy or focal.

https://launchpadlibrarian.net/732126396/buildlog_ci_update-manager_4748df9dae91d82120f49e43cfeb502134d6224d_BUILDING.txt.gz

[Jürgen Gmach (jugmac00)]

Hi Nathan,

Thanks for your report, and thanks for your patience.

Support for images is provided with `craft-providers` from the Starcraft team.

I had a look in their code base, and saw that this comment was removed by Callahan a while ago.

> # XXX: support xenial?

This makes me think whether Xenial was ever supported or not.

Have you used Xenial successfully with lpci before?

Can you make a case that we need to (re-)add support for Xenial? i.e. what is your usecase?

I am happy to reach out to the Starcraft team to discuss your requirements once I am aware.

[Nathan Teodosio (nteodosio)]

Hi Jürgen,

> Have you used Xenial successfully with lpci before?

No.

> Can you make a case that we need to (re-)add support for Xenial? i.e.
> what is your usecase?

Ubuntu Pro is exposed to the user base through update-manager, so we need to
keep it in shape from Noble until Xenial.

Am 17/06/2024 um 12:48 schrieb <email address hidden>:
> Hi Nathan,
>
> Thanks for your report, and thanks for your patience.
>
> Support for images is provided with `craft-providers` from the Starcraft
> team.
>
> I had a look in their code base, and saw that this comment was removed
> by Callahan a while ago.
>
> > # XXX: support xenial?
>
> This makes me think whether Xenial was ever supported or not.
>
> Have you used Xenial successfully with lpci before?
>
> Can you make a case that we need to (re-)add support for Xenial? i.e.
> what is your usecase?
>
> I am happy to reach out to the Starcraft team to discuss your
> requirements once I am aware.
>
>
> ** Changed in: lpci
> Status: New => Incomplete
>

[Jürgen Gmach (jugmac00)]

Hi Nathan,

I had a closer look into craft-providers, and a mapping for the xenial images is missing.

When patching it in via

```
craft-providers on  main [$!] via 🐍 v2.7.18 (venv)
❯ git diff
diff --git a/craft_providers/lxd/remotes.py b/craft_providers/lxd/remotes.py
index 272722e..33e4ec2 100644
--- a/craft_providers/lxd/remotes.py
+++ b/craft_providers/lxd/remotes.py
@@ -123,6 +123,12 @@ class RemoteImage:

 # mapping from supported bases to actual lxd remote images
 _PROVIDER_BASE_TO_LXD_REMOTE_IMAGE: Dict[Enum, RemoteImage] = {
+ ubuntu.BuilddBaseAlias.XENIAL: RemoteImage(
+ image_name="xenial",
+ remote_name=BUILDD_RELEASES_REMOTE_NAME,
+ remote_address=BUILDD_RELEASES_REMOTE_ADDRESS,
+ remote_protocol=ProtocolType.SIMPLESTREAMS,
+ ),
     ubuntu.BuilddBaseAlias.BIONIC: RemoteImage(
         image_name="core18",
         remote_name=BUILDD_RELEASES_REMOTE_NAME,
```

I got a xenial build to kick off, but unfortunately, craft-providers uses a lot of snap(d) commands and flags, which do not seem to be present in the relevant version for xenial.

So IMHO this would need quite some investment from the starcraft team to make xenial work.

I will create an issue on their tracker and ask for feedback.

[Jürgen Gmach (jugmac00)]

@nteodosio: I have created https://github.com/canonical/craft-providers/issues/582 upstream.

[Nathan Teodosio (nteodosio)]

Hi Jürgen,

thank you for taking care of this issue.

> So IMHO this would need quite some investment from the starcraft team to
> make xenial work.

It would be very nice to have that fixed, but to be clear at least for my case
it is not a blocking issue.