lpcraft conda build plugin should install and run conda-build outside of a conda environment
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lpci |
Fix Released
|
Low
|
Simone Pelosi |
Bug Description
Currently the conda-build plugin creates a conda environment and installs conda-build, python, etc into that environment, activates it, and performs a build. Conda-build itself then creates additional environments in order to perform the build.
For some packages, however, it appears that during the test phase, the initial conda environment is escaped. The packages search for `conda-inspect`, which is provided by conda-build, in order to inspect build artifact linkages, but cannot find this command as it is only installed in the environment.
In order to solve this I propose changing the default behavior of the conda-build plugin to not create an initial environment in the first place, as it does not encapsulate the build anyway. Instead of running `conda create...` we would just run `conda install ...`
Related branches
- Colin Watson (community): Approve
-
Diff: 134 lines (+12/-34)4 files modifiedNEWS.rst (+3/-0)
lpci/plugin/tests/test_plugins.py (+5/-19)
lpci/plugins/plugins.py (+3/-14)
setup.cfg (+1/-1)
Changed in lpcraft: | |
importance: | High → Low |
Changed in lpci: | |
assignee: | nobody → Simone Pelosi (pelpsi) |
status: | Triaged → In Progress |
Changed in lpci: | |
status: | In Progress → Fix Committed |
Changed in lpci: | |
status: | Fix Committed → Fix Released |
Sounds reasonable.
I am almost EOW (public holiday), so a MP is welcome. Otherwise I will create one next week, but let you review, as you actually use the plugin.