ec2 land refuses to land approved rc patch
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad Developer Utilities |
Triaged
|
Low
|
Unassigned | ||
Bug Description
We had a patch from wgrant to fix an rc issue - a regression an earlier patch of his added.
ec2 land <merge proposal url> complains "ec2: ERROR: Cannot land branches that haven't got approved code reviews. Get an 'Approved' vote so we can fill in the [r=REVIEWER] section."
However the bug *had* both review and rc approval - it seems ec2land doesn't consider release-critical tagged approvals as code reviews, but the merge proposal system replaces the rc vote with a regular vote if the review tries to do both.
Our policy here is that when something is rc approved the *merge proposal* is set to approved, and the rc vote is added, so I think ec2 land should treat an MP with:
status approved
1 vote release-critical <reviewer>
as code & rc approved by that person.
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: build-infrastructure |
| tags: | added: ec2land ec2test |
| affects: | launchpad → lp-dev-utils |
