Redirect loop when viewing file

[xaav]

When clicking on a link to view a file (example: http://bazaar.launchpad.net/~tsep-dev/tsep/2.0-dev/files/head:/web/app.php?file_id=app-20110423205850-npe15bktb5xalmnb-8), sometimes the file will cause a redirect loop.

[j.c.sackett (jcsackett)]

See also bug 741783, which may be a duplicate of this.

[xaav (xaav)]

This problem occurs when trying to view a file, the other problem occurs when trying to view the repository.

However, the same code could be causing both problems.

[asdfghjkl (asdfghjkl-deactivatedaccount1)]

When viewing a directory in loggerhead the url path can designate either the revno_url and absolutepath for the directory - or the file_id for the directory. When the file_id is used (as with breadcrumb links), the file listing is rendered with incorrect urls (the absolutepath of the *directory* is provided as the file_id for each *file*):

e.g.

http://127.0.0.1:8080/files/head:/someproject/src/main.py?file_id=src-20110504123105-ijtcm0g7a3txui1b-6

the view controller then interprets the file as a directory (based on the incorrect file_id) and passes it back to the inventory controller, which I presume passes it back to the view controller, and so on..

I don't know how best to fix it (this is my first look at the loggerhead source), or if it's already been fixed.. I thought I'd write this anyway.

[Martin Pool (mbp)]

ftr bug 741783 is not a dupe, or at least not obviously a dupe, so let's leave it separate and fixed.