=== modified file 'loggerhead/templatefunctions.py' --- loggerhead/templatefunctions.py 2011-03-02 14:07:21 +0000 +++ loggerhead/templatefunctions.py 2011-03-22 19:48:04 +0000 @@ -53,11 +53,11 @@ cgi.escape(filename), cgi.escape(filename)) else: return revision_link( - url, entry.revno, filename, '#' + filename) + url, entry.revno, filename, '#' + cgi.escape(filename)) else: def file_link(filename): return '<a href="%s%s" title="View changes to %s in revision %s">%s</a>' % ( - url(['/revision', entry.revno]), '#' + filename, cgi.escape(filename), + url(['/revision', entry.revno]), '#' + cgi.escape(filename), cgi.escape(filename), cgi.escape(entry.revno), cgi.escape(filename)) return _pt('revisionfilechanges').expand( entry=entry, file_changes=file_changes, file_link=file_link, **templatefunctions)
seems right to me. url is a dict, so url[...] is just a lookup and can use whatever data we put in it.
=== modified file 'loggerhead/ templatefunctio ns.py' templatefunctio ns.py 2011-03-02 14:07:21 +0000 templatefunctio ns.py 2011-03-22 19:48:04 +0000
cgi.escape( filename) , cgi.escape( filename) )
return revision_link( filename) ) filename) : filename) , filename) , cgi.escape( filename) ,
cgi. escape( entry.revno) , cgi.escape( filename) ) lechanges' ).expand(
entry= entry, file_changes= file_changes, file_link= file_link, **templatefunct ions)
--- loggerhead/
+++ loggerhead/
@@ -53,11 +53,11 @@
else:
- url, entry.revno, filename, '#' + filename)
+ url, entry.revno, filename, '#' + cgi.escape(
else:
def file_link(
return '<a href="%s%s" title="View changes to %s in revision %s">%s</a>' % (
- url(['/revision', entry.revno]), '#' + filename, cgi.escape(
+ url(['/revision', entry.revno]), '#' + cgi.escape(
return _pt('revisionfi
seems right to me. url is a dict, so url[...] is just a lookup and can use whatever data we put in it.