History uses removed Repository.get_revision_inventory()

Bug #528194 reported by Matt Nordhoff
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Critical
Matt Nordhoff

Bug Description

loggerhead.history.History.get_inventory() uses Repository.get_revision_inventory(), which was recently removed from bzr.dev (2.2.0b1). This breaks annotate, and presumably other things.

exceptions.AttributeError: 'CHKInventoryRepository' object has no attribute 'get_revision_inventory'
Traceback (most recent call last):
  File "/home/mnordhoff/loggerhead/loggerhead/apps/error.py", line 31, in __call__
    return self.application(environ, start_response)
  File "/var/lib/python-support/python2.5/paste/httpexceptions.py", line 632, in __call__
    return self.application(environ, start_response)
  File "/var/lib/python-support/python2.5/paste/deploy/config.py", line 276, in __call__
    return self.app(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/main.py", line 166, in new_app
    return application(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/main.py", line 143, in new_app
    return application(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/apps/transport.py", line 166, in __call__
    transport, self)(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/apps/transport.py", line 123, in __call__
    return self.app_for_non_branch(environ)(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/apps/transport.py", line 123, in __call__
    return self.app_for_non_branch(environ)(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/apps/transport.py", line 129, in __call__
    return self.app_for_branch(b)(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/apps/branch.py", line 165, in app
    return c(environ, start_response)
  File "/home/mnordhoff/loggerhead/loggerhead/controllers/__init__.py", line 93, in __call__
    vals.update(self.get_values(path, kwargs, headers))
  File "/home/mnordhoff/loggerhead/loggerhead/controllers/annotate_ui.py", line 111, in get_values
    file_id = history.get_file_id(revid, path)
  File "/home/mnordhoff/loggerhead/loggerhead/history.py", line 534, in get_file_id
    return self.get_inventory(revid).path2id(path)
  File "/home/mnordhoff/loggerhead/loggerhead/history.py", line 520, in get_inventory
    self._branch.repository.get_revision_inventory(revid))
AttributeError: 'CHKInventoryRepository' object has no attribute 'get_revision_inventory'

Related branches

description: updated
Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

That was easier than I was expecting...

Changed in loggerhead:
assignee: nobody → Matt Nordhoff (mnordhoff)
status: Triaged → In Progress
Changed in loggerhead:
status: In Progress → Fix Committed
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.