Add HTTP authentication support for standalone mode

Bug #518724 reported by Mark Lee
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mark Lee

Bug Description

I have added optional support for HTTP basic and digest authentication for the case where one is running loggerhead without a proxy in front of it (such as Apache), but does not wish to have the branch viewer "public". It uses Paste's built-in support for both kinds of auth (plus an htpasswd parser for basic auth from the Trac project, BSD-licensed), so there are no new external dependencies introduced (as HTTP auth support seems to have been in Paste since 0.4).

Related branches

Revision history for this message
Martin Albisetti (beuno) wrote :

Setting importance to high as this actually has a patch :)
Could you file a merge proposal for it?

The code looks good to me, in an ideal world we'd have tests for this, but I think the testsuite is currently broken due to some issue with imports.

Changed in loggerhead:
status: New → Triaged
importance: Undecided → High
Changed in loggerhead:
assignee: nobody → Mark Lee (malept)
status: Triaged → In Progress
Revision history for this message
Richie Ward (richies) wrote :

Rebased to master and seems to work ok:

Haven't tried test suite (yet)

Revision history for this message
Robert Collins (lifeless) wrote :

I'm dropping the priority of the bug to low: paste really can't scale in any serious fashion on its own, and doing auth in e.g. apache is pretty much the gold standard for production deployments. If Mark comes back and addresses the remaining todos in the merge proposal, or someone else contributes a patch, we'll certainly review them happily.

Changed in loggerhead:
importance: High → Low
Jelmer Vernooij (jelmer)
Changed in loggerhead-breezy:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers