Comparing a revision with itself broken

Bug #390029 reported by Tiefflieger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Unassigned
loggerhead
Fix Released
Critical
Michael Hudson-Doyle

Bug Description

If you click on http://bazaar.launchpad.net/~kaffeejunkies/cassiopeia/obsolete/revision/36 on the link "Compare with another revision", I expect that I can choose the other revision to compare with this one (rev 36).

But that does not happen, all that changes is that a new menu item "compare with revision 36" appears, clicking on that results in a page with "Internal Server Error" as the only content (no html, just these three words). I know that comparing a revision with itself is not that usefull, but it shouldn't return an error.

http://bazaar.launchpad.net/~kaffeejunkies/cassiopeia/obsolete/revision/36?remember=36&compare_revid=36 is the oopsing url.

OOPS-90422eb49bf1e605dc0161ef0b9f916d

alueError: need more than 1 value to unpack

    Traceback (most recent call last):
  Module oops_wsgi.middleware, line 208, in oops_middleware
    app(environ, oops_start_response))
  Module launchpad_loggerhead.debug, line 106, in wrapped_application
    result = application(environ, response_hook)
  Module __main__, line 165, in wrapped
  Module launchpad_loggerhead.debug, line 45, in wrapped
    return app(environ, start_response)
  Module paste.translogger, line 68, in __call__
    return self.application(environ, replacement_start_response)
  Module paste.deploy.config, line 285, in __call__
    return self.app(environ, start_response)
  Module __main__, line 149, in wrapped
  Module paste.wsgilib, line 179, in catch_errors
    app_iter = application(environ, start_response)
  Module launchpad_loggerhead.session, line 53, in __call__
    return self.cookie_handler(environ, start_response)
  Module paste.auth.cookie, line 305, in __call__
    return self.application(environ, response_hook)
  Module launchpad_loggerhead.session, line 80, in _process
    return self.application(environ, response_hook)
  Module paste.httpexceptions, line 636, in __call__
    return self.application(environ, start_response)
  Module launchpad_loggerhead.app, line 287, in __call__
    return view.app(environ, start_response)
  Module loggerhead.apps.branch, line 197, in app
    return c(environ, start_response)
  Module loggerhead.controllers, line 104, in __call__
    values = self.get_values(path, self.kwargs, headers)
  Module loggerhead.controllers.revision_ui, line 74, in get_values
    compare_revid, change.revid)
  Module loggerhead.history, line 796, in file_changes_for_revision_ids
    old_tree, new_tree = repo.revision_trees([old_revid, new_revid])
ValueError: need more than 1 value to unpack

Tags: oops

Related branches

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

In the general case, you might be interested in https://bugs.edge.launchpad.net/loggerhead/+bug/121720.

In the specific case of comparing a revision with itself being broken, you're right, and it's probably easy to fix. I'll use this report to track the progress of this specific bug.

Changed in loggerhead:
assignee: nobody → Michael Hudson (mwhudson)
importance: Undecided → High
status: New → Triaged
summary: - Compare with revision broken
+ Comparing a revision with itself broken
Revision history for this message
Robert Collins (lifeless) wrote :

@mwhudson - I presume this fell off your radar?

description: updated
Changed in loggerhead:
importance: High → Critical
tags: added: oops
description: updated
Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Robert Collins (lifeless) wrote :

LP task for deployment.

Changed in loggerhead:
status: Triaged → In Progress
Changed in loggerhead:
status: In Progress → Fix Committed
Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

This no longer occurs, marking as fix released

Changed in launchpad:
status: Triaged → Fix Released
Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Sorry, I mean in launchpad itself. I'm not sure if it's been "released" in loggerhead yet

Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.