Comparing a revision with itself broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Unassigned | ||
loggerhead |
Fix Released
|
Critical
|
Michael Hudson-Doyle |
Bug Description
If you click on http://
But that does not happen, all that changes is that a new menu item "compare with revision 36" appears, clicking on that results in a page with "Internal Server Error" as the only content (no html, just these three words). I know that comparing a revision with itself is not that usefull, but it shouldn't return an error.
http://
OOPS-90422eb49bf1e605dc0161ef0b9f916d
alueError: need more than 1 value to unpack
Traceback (most recent call last):
Module oops_wsgi.
app(environ, oops_start_
Module launchpad_
result = application(
Module __main__, line 165, in wrapped
Module launchpad_
return app(environ, start_response)
Module paste.translogger, line 68, in __call__
return self.applicatio
Module paste.deploy.
return self.app(environ, start_response)
Module __main__, line 149, in wrapped
Module paste.wsgilib, line 179, in catch_errors
app_iter = application(
Module launchpad_
return self.cookie_
Module paste.auth.cookie, line 305, in __call__
return self.applicatio
Module launchpad_
return self.applicatio
Module paste.httpexcep
return self.applicatio
Module launchpad_
return view.app(environ, start_response)
Module loggerhead.
return c(environ, start_response)
Module loggerhead.
values = self.get_
Module loggerhead.
compare_revid, change.revid)
Module loggerhead.history, line 796, in file_changes_
old_tree, new_tree = repo.revision_
ValueError: need more than 1 value to unpack
Related branches
- j.c.sackett (community): Approve
- Richard Harding (community): Approve (code*)
-
Diff: 13 lines (+2/-1)1 file modifiedloggerhead/history.py (+2/-1)
Changed in loggerhead: | |
status: | Triaged → In Progress |
Changed in loggerhead: | |
status: | In Progress → Fix Committed |
Changed in loggerhead: | |
status: | Fix Committed → Fix Released |
In the general case, you might be interested in https:/ /bugs.edge. launchpad. net/loggerhead/ +bug/121720.
In the specific case of comparing a revision with itself being broken, you're right, and it's probably easy to fix. I'll use this report to track the progress of this specific bug.