6 digit line numbers get cutoff

Bug #310255 reported by Vadim Peretokin on 2008-12-21
2
Affects Status Importance Assigned to Milestone
loggerhead
Low
Cruz Bishop

Bug Description

Loggerhead cuts off the last digit from a 6 digit line number when doing diffs. This is demonstrated here: http://bazaar.launchpad.net/~vadi-mapper-dev/vadi-mapper/main/revision/160 (scroll down to bottom)

Related branches

Martin Albisetti (beuno) on 2009-01-23
Changed in loggerhead:
importance: Undecided → Medium
status: New → Triaged
Michael Hudson-Doyle (mwhudson) wrote :

Well, actually the linenumber column is using a relative width, so if you make your window wider you'll see more digits :)

It's fairly lame I guess, but I can't think of how to do better in CSS's model :/

Should it not offer a scrollbar? The code goes to overflow oddly too.

Max Kanat-Alexander (mkanat) wrote :

I would say that this qualifies as fairly Low priority based on the fact that very few files have line numbers that high.

Changed in loggerhead:
importance: Medium → Low
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/20/2011 02:50 AM, Max Kanat-Alexander wrote:
> I would say that this qualifies as fairly Low priority based on the fact
> that very few files have line numbers that high.
>
> ** Changed in: loggerhead
> Importance: Medium => Low
>

I think the main issue was because of version numbers of stuff like
Emacs, where you have >100k revisions.

So more an issue on the "changes" page, not individual file annotation.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk04fdcACgkQJdeBCYSNAAPO4QCgoVxzL29JgoRgbFNtNTxPMc1c
WNQAn2i7hBrzlU68fqLSjaJlqElGcCHj
=V68x
-----END PGP SIGNATURE-----

Max Kanat-Alexander (mkanat) wrote :

> So more an issue on the "changes" page, not individual file annotation.

  Actually, the bug report is against the "diff" page. There is an example URL provided.

Changed in loggerhead:
status: Triaged → In Progress
assignee: nobody → Cruz Bishop (cruzjbishop)
Cruz Bishop (cruzjbishop) wrote :

Opened a merge request to fix this. :)

Changed in loggerhead:
status: In Progress → Fix Committed
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers