6 digit line numbers get cutoff

[Vadim Peretokin]

Loggerhead cuts off the last digit from a 6 digit line number when doing diffs. This is demonstrated here: http://bazaar.launchpad.net/~vadi-mapper-dev/vadi-mapper/main/revision/160 (scroll down to bottom)

[Michael Hudson-Doyle (mwhudson)]

Well, actually the linenumber column is using a relative width, so if you make your window wider you'll see more digits :)

It's fairly lame I guess, but I can't think of how to do better in CSS's model :/

[Vadim Peretokin (vperetokin)]

Should it not offer a scrollbar? The code goes to overflow oddly too.

[Max Kanat-Alexander (mkanat)]

I would say that this qualifies as fairly Low priority based on the fact that very few files have line numbers that high.

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/20/2011 02:50 AM, Max Kanat-Alexander wrote:
> I would say that this qualifies as fairly Low priority based on the fact
> that very few files have line numbers that high.
>
> ** Changed in: loggerhead
> Importance: Medium => Low
>

I think the main issue was because of version numbers of stuff like
Emacs, where you have >100k revisions.

So more an issue on the "changes" page, not individual file annotation.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk04fdcACgkQJdeBCYSNAAPO4QCgoVxzL29JgoRgbFNtNTxPMc1c
WNQAn2i7hBrzlU68fqLSjaJlqElGcCHj
=V68x
-----END PGP SIGNATURE-----

[Max Kanat-Alexander (mkanat)]

> So more an issue on the "changes" page, not individual file annotation.

  Actually, the bug report is against the "diff" page. There is an example URL provided.

[Cruz Bishop (cruzjbishop)]

Opened a merge request to fix this. :)