Long revision comment does not wrap

Bug #276768 reported by Matt Layman
42
This bug affects 4 people
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
High
Francesco Del Degan

Bug Description

When I commit my code, I use `bzr commit -m "<comment here>"`. I've noticed that when I look at lp's revision pages, any of my comments that are long don't wrap within the page's box (i.e., the text goes right into the list of modified items). I don't know if it's because my comments have no new line characters, but I think loggerhead should be smart enough to wrap long comments correctly.

Here is an example: http://bazaar.launchpad.net/~laymansterms/entertainer/labels/revision/310

I use the standard Firefox that is in Hardy with no plugins.

I don't know if this an upstream problem with loggerhead, but I have no way of testing that.

Related branches

Martin Albisetti (beuno)
Changed in launchpad-loggerhead:
assignee: nobody → beuno
importance: Undecided → Medium
status: New → Confirmed
Martin Albisetti (beuno)
Changed in loggerhead:
assignee: nobody → beuno
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Peter Bui (pnutzh4x0r) wrote :

I linked my attempted fix branch above. It is possible to play around with the width property of the TextWrapper class to determine what is the optimal wrapping length.

Revision history for this message
Martin Albisetti (beuno) wrote :

I will try and look at the branch this week. Thanks!

Changed in loggerhead:
status: Confirmed → Triaged
assignee: Martin Albisetti (beuno) → nobody
Changed in launchpad-loggerhead:
assignee: Martin Albisetti (beuno) → nobody
Changed in launchpad-loggerhead:
status: Triaged → Invalid
Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

Peter--for some reason, I can't merge your branch to see what has changed from the base loggerhead. Could you re-do the branch and I can see it again? I'm assuming you're using CSS pre-wrap methods?

Revision history for this message
Peter Bui (pnutzh4x0r) wrote : Re: [Bug 276768] Re: Long revision comment does not wrap

Max:

I can't access the bugs page using the URL below (launchpad is messed up
I think), so I can't look up what I did. I'm pretty sure I didn't use
CSS. Unfortunately, I don't use bzr or loggerhead any more, so I won't
be of much use. Sorry and good luck.

On 08:54 Thu 20 Jan , Max Kanat-Alexander wrote:
> Peter--for some reason, I can't merge your branch to see what has
> changed from the base loggerhead. Could you re-do the branch and I can
> see it again? I'm assuming you're using CSS pre-wrap methods?
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/276768
>
> Title:
> Long revision comment does not wrap

--
Peter Bui

Changed in loggerhead:
importance: Medium → High
Changed in loggerhead:
assignee: nobody → Francesco "pr0gg3d" Del Degan (pr0gg3d)
status: Triaged → In Progress
Changed in loggerhead:
status: In Progress → Fix Committed
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.