root directory view traceback

[Russ Brown]

Running trunk revision 191 on bzr 1.5, I get the following traceback only when viewing the root folder. Other non-branch subdirectories render fine.

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/paste/httpserver.py", line 1053, in process_request_in_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python2.5/SocketServer.py", line 254, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python2.5/SocketServer.py", line 522, in __init__
    self.handle()
  File "/usr/lib/python2.5/site-packages/paste/httpserver.py", line 432, in handle
    BaseHTTPRequestHandler.handle(self)
  File "/usr/lib/python2.5/BaseHTTPServer.py", line 316, in handle
    self.handle_one_request()
  File "/usr/lib/python2.5/site-packages/paste/httpserver.py", line 427, in handle_one_request
    self.wsgi_execute()
  File "/usr/lib/python2.5/site-packages/paste/httpserver.py", line 287, in wsgi_execute
    self.wsgi_start_response)
  File "/usr/lib/python2.5/site-packages/paste/deploy/config.py", line 276, in __call__
    return self.app(environ, start_response)
  File "/usr/lib/python2.5/site-packages/paste/translogger.py", line 67, in __call__
    return self.application(environ, replacement_start_response)
  File "/usr/lib/python2.5/site-packages/paste/httpexceptions.py", line 632, in __call__
    return self.application(environ, start_response)
  File "/home/admin/loggerhead/loggerhead/apps/filesystem.py", line 79, in __call__
    self.folder, self)(environ, start_response)
  File "/home/admin/loggerhead/loggerhead/apps/filesystem.py", line 58, in __call__
    return self.app_for_non_branch(environ)(environ, start_response)
  File "/home/admin/loggerhead/loggerhead/controllers/__init__.py", line 83, in __call__
    vals.update(self.get_values(h, args, kw, headers))
  File "/home/admin/loggerhead/loggerhead/controllers/directory_ui.py", line 67, in get_values
    dirs.append(DirEntry(d, parity, b))
  File "/home/admin/loggerhead/loggerhead/controllers/directory_ui.py", line 34, in __init__
    branch.repository.get_revision(branch.last_revision()).timestamp)
  File "<string>", line 4, in get_revision_read_locked
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/knitrepo.py", line 197, in get_revision
    return self.get_revision_reconcile(revision_id)
  File "<string>", line 4, in get_revision_reconcile_read_locked
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 1086, in get_revision_reconcile
    return self._get_revisions([revision_id])[0]
  File "<string>", line 4, in _get_revisions_read_locked
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 1100, in _get_revisions
    self.get_transaction())
  File "/usr/lib/python2.5/site-packages/bzrlib/store/revision/knit.py", line 88, in get_revisions
    texts = self._get_serialized_revisions(revision_ids, transaction)
  File "/usr/lib/python2.5/site-packages/bzrlib/store/revision/knit.py", line 103, in _get_serialized_revisions
    return vf.get_texts(revision_ids)
  File "/usr/lib/python2.5/site-packages/bzrlib/knit.py", line 1140, in get_texts
    return [''.join(l) for l in self.get_line_list(version_ids)]
  File "/usr/lib/python2.5/site-packages/bzrlib/knit.py", line 1145, in get_line_list
    self.check_not_reserved_id(version_id)
  File "/usr/lib/python2.5/site-packages/bzrlib/versionedfile.py", line 60, in check_not_reserved_id
    revision.check_not_reserved_id(version_id)
  File "/usr/lib/python2.5/site-packages/bzrlib/revision.py", line 437, in check_not_reserved_id
    raise errors.ReservedId(revision_id)
ReservedId: Reserved revision-id {null:}

[Martin Albisetti (beuno)]

Also happens with 1.6.

We should filter out NULL revisions when getting the timestamp from the last revision