log rotation actually doesn't save old logs (it truncates them)

[Max Kanat-Alexander]

I have log.roll = 'weekly' in my loggerhead.conf (with current trunk).

I just noticed today that I now have about nine months' worth of files that have only one line in them. It appears that loggerhead rolls the log, writes a single *new* line to the rolled log (discarding the entire log history) and then starts writing new stuff to the original file (without saving any of the old history).

[Martin Albisetti (beuno)]

I've committed a change to trunk that should fix this.
Could you verify it? (maybe make the logs rotate daily for a while?)

Thanks!

[Max Kanat-Alexander (mkanat)]

Yes, I can verify that that fixed it! Thank you. :-)