Viewing revision might cause oops
Bug #1921634 reported by
Vitaliy Kanev
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
loggerhead |
Fix Released
|
High
|
Colin Watson |
Bug Description
OOPS-ID: OOPS-b184652fa879557335d82f2cdb7870bf
Tested against revision 624 of lp:ubuntu-wallpapers - https:/
The problematic page simply says: """
Oops!
Something broke while generating the page. Please try again in a few minutes, and if the problem persists file a bug at https:/
"""
Note that revisions 623 and 625 work fine
Nothing useful in browser console.
Maybe this is because of a large binary file being uploaded to a revision or (which I don't think it is) storage failure on some Launchpad server?
Related branches
lp:~cjwatson/loggerhead/revision-ui-quote-from-bytes
Merged
into
lp:loggerhead
- Ioana Lasc (community): Approve
-
Diff: 55 lines (+26/-1)2 files modifiedloggerhead/controllers/revision_ui.py (+3/-1)
loggerhead/tests/test_controllers.py (+23/-0)
~cjwatson/launchpad:loggerhead-r513
Merged
into
launchpad:master
- Ioana Lasc (community): Approve
-
Diff: 25 lines (+3/-3)2 files modifiedutilities/sourcedeps.cache (+2/-2)
utilities/sourcedeps.conf (+1/-1)
Changed in loggerhead: | |
status: | Triaged → In Progress |
assignee: | nobody → Colin Watson (cjwatson) |
Changed in loggerhead: | |
status: | In Progress → Fix Committed |
Changed in loggerhead: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
KeyError: u'\xe2'
Traceback (most recent call last): middleware, line 210, in oops_middleware response) ) config, line 291, in __call__ loggerhead. wsgi, line 90, in wrapped environ, start_response) loggerhead. wsgi, line 67, in wrapped loggerhead. revision, line 34, in __call__ n(environ, response_hook) loggerhead. session, line 85, in __call__ n(environ, response_hook) tions, line 640, in __call__ n(environ, start_response) loggerhead. app, line 288, in __call__ apps.branch, line 207, in app controllers, line 129, in __call__ add_template_ values( values) controllers. revision_ ui, line 142, in add_template_values item.filename) ) controllers. revision_ ui, line 35, in dq quote(urlutils. quote(p, safe=''))
Module oops_wsgi.
app(environ, oops_start_
Module paste.deploy.
return self.app(environ, start_response)
Module launchpad_
app, environ, start_response, request_done_err, request_done_ok)
Module paste.wsgilib, line 185, in catch_errors
app_iter = application(
Module launchpad_
return app(environ, response_hook)
Module launchpad_
return self.applicatio
Module launchpad_
return self.applicatio
Module paste.httpexcep
return self.applicatio
Module launchpad_
return view.app(environ, start_response)
Module loggerhead.
return c(environ, start_response)
Module loggerhead.
self.
Module loggerhead.
dq(
Module loggerhead.
return urlutils.
Module breezy.urlutils, line 156, in quote_from_bytes
return ''.join(map(quoter, s))
KeyError: u'\xe2'