bzr file view/download broken

[Selene ToyKeeper]

It looks like something recent broke the ability to view or download files in bzr repositories.

For example, go to any project which uses bzr, browse the code, and click on a file to view or download it.

1. Go to https://bazaar.launchpad.net/~adamreichold/qpdfview/trunk/files
2. Click "README" or "TODO" or any other file.

Actual result: OOPS-f4a815585986ab48bc2f8727b6985bf6

Expected result: Display the contents of the file.

[Selene ToyKeeper (toykeeper)]

Traceback:

https://paste.ubuntu.com/p/Y3yGDV78c8/

TypeError: README

    Traceback (most recent call last):
  Module oops_wsgi.middleware, line 210, in oops_middleware
    app(environ, oops_start_response))
  Module paste.deploy.config, line 291, in __call__
    return self.app(environ, start_response)
  Module launchpad_loggerhead.wsgi, line 70, in wrapped
    app, environ, start_response, request_done_err, request_done_ok)
  Module paste.wsgilib, line 185, in catch_errors
    app_iter = application(environ, start_response)
  Module launchpad_loggerhead.session, line 39, in __call__
    return self.cookie_handler(environ, start_response)
  Module paste.auth.cookie, line 322, in __call__
    return self.application(environ, response_hook)
  Module launchpad_loggerhead.session, line 66, in _process
    return self.application(environ, response_hook)
  Module paste.httpexceptions, line 640, in __call__
    return self.application(environ, start_response)
  Module launchpad_loggerhead.app, line 291, in __call__
    return view.app(environ, start_response)
  Module loggerhead.apps.branch, line 207, in app
    return c(environ, start_response)
  Module loggerhead.controllers, line 110, in __call__
    values = self.get_values(path, self.kwargs, headers)
  Module loggerhead.controllers.view_ui, line 160, in get_values
    'contents': self.file_contents(path, revid),
  Module loggerhead.controllers.view_ui, line 92, in file_contents
    file_lines = self.text_lines(path, revid)
  Module loggerhead.controllers.view_ui, line 64, in text_lines
    tree = self.tree_for(path, revid)
  Module loggerhead.controllers.view_ui, line 54, in tree_for
    raise TypeError(path)
TypeError: README

[Colin Watson (cjwatson)]

The OOPS reads:

  TypeError: README

    Traceback (most recent call last):
  Module oops_wsgi.middleware, line 210, in oops_middleware
    app(environ, oops_start_response))
  Module paste.deploy.config, line 291, in __call__
    return self.app(environ, start_response)
  Module launchpad_loggerhead.wsgi, line 70, in wrapped
    app, environ, start_response, request_done_err, request_done_ok)
  Module paste.wsgilib, line 185, in catch_errors
    app_iter = application(environ, start_response)
  Module launchpad_loggerhead.session, line 39, in __call__
    return self.cookie_handler(environ, start_response)
  Module paste.auth.cookie, line 322, in __call__
    return self.application(environ, response_hook)
  Module launchpad_loggerhead.session, line 66, in _process
    return self.application(environ, response_hook)
  Module paste.httpexceptions, line 640, in __call__
    return self.application(environ, start_response)
  Module launchpad_loggerhead.app, line 291, in __call__
    return view.app(environ, start_response)
  Module loggerhead.apps.branch, line 207, in app
    return c(environ, start_response)
  Module loggerhead.controllers, line 110, in __call__
    values = self.get_values(path, self.kwargs, headers)
  Module loggerhead.controllers.view_ui, line 160, in get_values
    'contents': self.file_contents(path, revid),
  Module loggerhead.controllers.view_ui, line 92, in file_contents
    file_lines = self.text_lines(path, revid)
  Module loggerhead.controllers.view_ui, line 64, in text_lines
    tree = self.tree_for(path, revid)
  Module loggerhead.controllers.view_ui, line 54, in tree_for
    raise TypeError(path)
TypeError: README

[Tom Wardill (twom)]

There was an update to loggerhead rolled out in the latest deployment. Looks like something has gone a bit wrong.
Looking at a fix now.

[Tom Wardill (twom)]

Latest update:
This is caused by r498.1.2 of loggerhead, which ironically, I can't link here as it can't be displayed due to this bug.

Looks like a change to using file paths rather than file ids, when the file path is somehow not a `str`.

It works in staging and development, but not in production. Investigating why production set up appears to be different enough to cause this.

[Tom Wardill (twom)]

Configuration was a mistaken reading of the OOPS, it's a py2/py3 compatibility error in string types.

Proposed a fix.

[Tom Wardill (twom)]

The fix for this was just deployed.
Sorry for the delay, we had an unfortunate clash with the timing to upgrade some of our CI systems.

[Selene ToyKeeper (toykeeper)]

> Sorry for the delay...

No, thanks for the quick fix! :)

[DanglingPointer (ferncasado)]

Thanks for sorting this out quickly!