current filename on filtered changes view is a stringified exception when the fileid is not present in the starting revision

[Matthew Flaschen]

http://bazaar.launchpad.net/~epics-core/epics-base/3.14/changes?filter_file_id=recaai.c-19941025185436-63xdujwxw18vn1oh-1

See the filename in the prose at the top of the page.

[Michael Hudson-Doyle (mwhudson)]

Oh, I think what's happened here is that the file that you're filtering on has been deleted in tip.

I'm not sure what to do about this, but at least AFAICT it only affects the title...

[Peter Bui (pnutzh4x0r)]

I can't reproduce this problem in trunk, so perhaps it has already been fixed in the later versions of loggerhead.

[Peter Bui (pnutzh4x0r)]

Nevermind, I was browsing at the wrong revision... I see the problem too.

[Martin Albisetti (beuno)]

I can't reproduce this anymore. Please open up again if it happens again.

[Matthew Flaschen (matthew-flaschen)]

It has never stopped happening. Do exactly what I said in the initial report, and you will see the error. I don't understand why you would mark the report as incomplete without asking for additional information.

[Andrew Johnson (anj)]

The instructions in the original report don't seem to work now, but I'm seeing this exception in my project at http://bazaar.launchpad.net/~epics-core/epics-base/3.14/changes?filter_file_id=recaai.c-19941025185436-63xdujwxw18vn1oh-1 which shows the log of a file that was deleted from the epics-base repository as part of a rename (from recAai.c to aaiRecord.c) done using the CVS delete + add technique long before the Bazaar conversion.

I am trying to follow the file's history through the rename. Using loggerhead I find the revision where it was added with the new name http://bazaar.launchpad.net/~epics-core/epics-base/3.14/revision/1997 Then click "Older" and "browse files at revision 1996" at which point I have to click through the directory hierarchy to find the file with its old name. That takes me to http://bazaar.launchpad.net/~epics-core/epics-base/3.14/files/1996/src/rec/?start_revid=12049 where I click the file recAai.c and then "View changes to this file."

The line which should contain the filename actually says this:

~epics-core/epics-base/3.14 : changes to Exception: The file id "recaai.c-19941025185436-63xdujwxw18vn1oh-1" is not present in the tree <bzrlib.inventory.CHKInventory object at 0x11a6eed0>. from revision 12049

[Robert Collins (lifeless)]

@Andrew which page has the bad link on it?

[Andrew Johnson (anj)]

The very first link in my previous comment. When I go there, immediately below the two Changes/Files tabs is a title that now says:

~epics-core/epics-base/3.14 : changes to Exception: The file id "recaai.c-19941025185436-63xdujwxw18vn1oh-1" is not present in the tree <bzrlib.inventory.CHKInventory object at 0x2b998efd3d50>. from revision 12211

The part starting "Exception: The file" up to the end of the hex number and full stop is rendered in gray and should contain a filename, not the exception message it currently shows.

[Andrew Johnson (anj)]

@Robert: On re-reading your question I don't think this is really a bad link, contrary to the wording of the bug title (since my symptoms do match those described by the OP), it's just that the page that I talked about has a problem getting the filename of the file it's trying to show the history for, which has long since been deleted. This also has nothing to do with validating user input (which is the subject of the bug he referred to).

[Robert Collins (lifeless)]

Ok, so we should show a 404 here I think. I agree that we could do
history walking to guess, but thats a long term thing - e.g. a
separate bug.

[Robert Collins (lifeless)]

Actually, not a 404 as my email reply says, its doing history walking already so we should be able to pick a better inventory to use. Or something

[Andrew Johnson (anj)]

It's definitely not a 404, the file recAai.c used to exist, so I should be able to examine its history, right up until the point when it was deleted, which was between revisions 1996 and 1997 (see my Comment #6). Loggerhead does correctly show the file contents at revision 1996 (see http://bazaar.launchpad.net/~epics-core/epics-base/3.14/view/1996/src/rec/recAai.c?start_revid=12211 ) but asking to "view changes to this file" from the latter page goes to the page with the bad title. The rest of the page below the title looks mostly OK, but there should be another row in the table showing the commit when the file was deleted.