LoCo Team Portal

Team Approved/Expire dates don't require time.

Bug #494950 reported by Dave Walker
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
LoCo Team Portal
Confirmed
Medium
Unassigned

Bug Description

The approved_date and expires_date are of type DateTimeField which also gives us the following representation:
2010-06-22 13:33:03.308369

I would argue that that time element is irrelevant, and the only important data is the date.

Related branches

lp:~davewalker/loco-team-portal/bug494950
Daniel Holbach (community): Approve
Diff: 13 lines (+2/-2)
1 file modified
loco_directory/teams/models.py (+2/-2)
lp:~dholbach/loco-team-portal/profile
Michael Hall (community): Approve
Diff: 1539 lines (+1182/-47)
23 files modified
loco_directory/common/launchpad.py (+18/-2)
loco_directory/events/forms.py (+2/-2)
loco_directory/events/migrations/0002_add_profile_fields.py (+170/-0)
loco_directory/events/migrations/0003_migrate_profile_data.py (+173/-0)
loco_directory/events/migrations/0004_remove_user.py (+181/-0)
loco_directory/events/models.py (+6/-6)
loco_directory/events/views.py (+7/-3)
loco_directory/services/urls.py (+1/-1)
loco_directory/services/views.py (+4/-3)
loco_directory/settings.py (+3/-0)
loco_directory/teams/admin.py (+1/-6)
loco_directory/teams/management/commands/lpupdate.py (+26/-12)
loco_directory/teams/migrations/0002_add_mugshot_field.py (+1/-0)
loco_directory/teams/migrations/0005_add_profile_fields.py (+142/-0)
loco_directory/teams/migrations/0006_migrate_profile_fields.py (+140/-0)
loco_directory/teams/migrations/0007_remove_old_person_fields.py (+136/-0)
loco_directory/teams/models.py (+4/-7)
loco_directory/templates/events/team_event_detail_attendees.inc.html (+1/-1)
loco_directory/templates/events/team_event_detail_comments.inc.html (+1/-1)
loco_directory/templates/teams/team_detail.html (+9/-3)
loco_directory/userprofiles/admin.py (+7/-0)
loco_directory/userprofiles/migrations/0001_initial.py (+89/-0)
loco_directory/userprofiles/models.py (+60/-0)
lp:~ronnie.vd.c/loco-team-portal/494950_db_approved
Michael Hall (community): Needs Information
Diff: 128 lines (+124/-0)
1 file modified
loco_directory/teams/migrations/0013_auto__chg_field_team_approved_date.py (+124/-0)
Daniel Holbach (dholbach)
Changed in loco-directory:
importance: Undecided → Medium
milestone: none → 0.1.1
status: New → Triaged
Daniel Holbach (dholbach)
Changed in loco-directory:
status: Triaged → Fix Committed
Daniel Holbach (dholbach)
Changed in loco-directory:
status: Fix Committed → Fix Released
Revision history for this message
Laura Czajkowski (czajkowski) wrote :

This is still an issue and can be seen on http://loco.ubuntu.com/teams/ubuntu-ie

Revision history for this message
Daniel Holbach (dholbach) wrote :

Reopening, still a problem.

Changed in loco-directory:
milestone: 0.1.1 → none
status: Fix Released → Triaged
Revision history for this message
Chris Johnston (cjohnston) wrote :

On a local install it seems to be correct. Is it possible that the info in the database includes the times still and they need to be removed from there?

Revision history for this message
Daniel Holbach (dholbach) wrote :

<dholbach> cjohnston, I think that's a problem in the migrations - it's a missing migration (so it's changed in the model, but not in the database)
<dholbach> cjohnston, it might be fixed in my profile branch (it has one of those migrations which was added automatically)
<cjohnston> Gotcha.. all I know is I can't reproduce it...
<dholbach> go back to a very old version of the code, create a database, run all migrations
<cjohnston> ahh

Daniel Holbach (dholbach)
Changed in loco-directory:
assignee: nobody → Daniel Holbach (dholbach)
status: Triaged → In Progress
Daniel Holbach (dholbach)
Changed in loco-directory:
milestone: none → 0.2.18
status: In Progress → Fix Committed
Chris Johnston (cjohnston)
Changed in loco-directory:
status: Fix Committed → Fix Released
Revision history for this message
Chris Johnston (cjohnston) wrote :

This bug still isn't fixed.

Changed in loco-directory:
status: Fix Released → Confirmed
milestone: 0.2.18 → none
assignee: Daniel Holbach (dholbach) → nobody
Revision history for this message
Ronnie (ronnie.vd.c) wrote :

The change happens somewhere in the 0.1 version of LP.

What i did to hopefully fix it:

changes models.py of the head version:
 - DateField to DateTimeField

./manage.py schemamigration --auto teams

Change in the 0013_auto__chg_field_team_approved_date.py:
 - Flipped the lines from the functions: forwards and backwards

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.