LoCo Team Portal

profile images not displaying correctly if no image on LP

Bug #734520 reported by Laura Czajkowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Undecided
Unassigned
LoCo Team Portal
Fix Committed
Medium
Adnane Belmadiaf

Bug Description

If you have an image stored on LP your image shows up fine on the LD. If you are registering to attend using openiduser you get a no image which is fine. However if you've no image on LP, the LD tries to bring in some image and shows up on the LD as a corrupt image. see examples here http://loco.ubuntu.com/events/team/615/detail/

Related branches

lp:~cjohnston/loco-team-portal/mugshot
Adnane Belmadiaf: Approve
Diff: 19 lines (+2/-0)
1 file modified
loco_directory/templates/events/team_event_detail_attendees.inc.html (+2/-0)
lp:~daker/loco-team-portal/fix.734520
Chris Johnston: Approve
Diff: 56 lines (+11/-11)
2 files modified
loco_directory/common/launchpad.py (+9/-7)
loco_directory/userprofiles/management/commands/update-profiles.py (+2/-4)
Chris Johnston (cjohnston)
Changed in loco-directory:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Adnane Belmadiaf (daker) wrote :

The problem we have here is that Launchpad doesn't return an image when the user doesn't have a mugshot like on this example https://api.launchpad.net/1.0/~bigreds/logo, so i believe this bug should be fixed in Launchpad.

Revision history for this message
Robert Collins (lifeless) wrote :

Sorry, I don't understand. If you have no image, LP cannot provide one. Can you please provide reproduction instructions or something so we can understand better?

Changed in launchpad:
status: New → Incomplete
Revision history for this message
William Grant (wgrant) wrote :

There seems to be some confusion: the URL given in comment #1 404s -- it doesn't return that string as an image.

Some argue that Launchpad should return the stock image if no custom one is set, but that seems like it would serve only to make life harder for consumers who desire to have the default image blend with their own theme.

Revision history for this message
Adnane Belmadiaf (daker) wrote :

Yes wgrant, you are right.
@lifeless see bug #713873.

Adnane Belmadiaf (daker)
Changed in loco-directory:
assignee: nobody → Adnane Belmadiaf (daker)
status: Confirmed → In Progress
Revision history for this message
Robert Collins (lifeless) wrote :

@adnane what about it?

Revision history for this message
Данило Шеган (danilo) wrote :

Sounds to me like this was resolved, or is a duplicate of 713873 as far as LP is concerned. If anyone disagrees, please re-open with clarifications.

Changed in launchpad:
status: Incomplete → Invalid
Tarmac WebDev (tarmac-webdev)
Changed in loco-team-portal:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.