Python 3 Support
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
localmail |
New
|
Undecided
|
Unassigned |
Bug Description
When importing Localmail on Python 3.6.4 on Windows 10, I see the following stack trace. It appears that the imports in cred.py should be re-written to use relative imports.
-------
ModuleNotFoundError Traceback (most recent call last)
<ipython-
----> 1 import localmail
~\.virtualenvs\
17 from twisted.internet import reactor
18 from twisted.cred import portal, checkers
---> 19 from .cred import TestServerRealm, CredentialsNonC
20 from .smtp import TestServerESMTP
21 from .imap import TestServerIMAPF
~\.virtualenvs\
19 from twisted.mail import smtp, imap4
20
---> 21 from imap import IMAPUserAccount
22 from smtp import MemoryDelivery
23
ModuleNotFoundE
Related branches
- Simon Davy: Approve
-
Diff: 543 lines (+221/-62)10 files modified.bzrignore (+1/-0)
localmail/cred.py (+11/-8)
localmail/imap.py (+6/-6)
localmail/inbox.py (+36/-16)
localmail/smtp.py (+18/-12)
tests/helpers.py (+6/-3)
tests/spam/check.py (+10/-9)
tests/test_localmail.py (+129/-5)
tox.ini (+2/-1)
twisted/plugins/localmail_tap.py (+2/-2)
Actually there's a bit more work to support Python 3 than just fixing the imports.