The radio button for LDAP appears as not selected after deployment

[guillaume thouvenin]

When you deploy InfluxDB or ES plugin with LDAP enabled, the radio button is shown as not selected after the deployment. It is not the case for the LMA Infrastructure plugin.

= update of the description for Fuelers =

I observed it in MOS 8. But I'm pretty sure that is also in MOS 9 but need to be confirmed.

This bug appears when you use a radio button that has the same name in different plugins. For example if we declare in one plugin (let say the influxdb plugin):

 ldap_protocol:
    type: "radio"
    value: 'ldap'
    weight: 180
    label: 'LDAP protocol'
    values:
      - data: "ldap"
        label: "LDAP"
      - data: "ldaps"
        label: "LDAPS"
    restrictions:
      - condition: "settings:influxdb_grafana.ldap_enabled.value == false"
        action: hide

and in the other plugin (like elasticsearch plugin):

  ldap_protocol:
    type: "radio"
    value: 'ldap'
    weight: 110
    label: 'LDAP protocol'
    values:
      - data: "ldap"
        label: "LDAP"
      - data: "ldaps"
        label: "LDAPS"
    restrictions:
      - condition: "settings:elasticsearch_kibana.ldap_enabled.value == false"
        action: hide

Then in the Fuel UI the radio button will appear only into one plugin.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352816

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352817

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352819

[guillaume thouvenin (guillaume-thouvenin)]

I just tested on my environment (it is MOS 8) and using a different label name for all plugins solves the issue.

[guillaume thouvenin (guillaume-thouvenin)]

In fact the solution is to use a different name for radio button for all plugins. There is probably a bug in the Fuel UI where ID of radio button are kind of mixed if the same label appears into several plugins.

I added the Fuel team here.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352816
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-elasticsearch-kibana/commit/?id=459a7f272390f48114cc03377ce98add1154371c
Submitter: Jenkins
Branch: master

commit 459a7f272390f48114cc03377ce98add1154371c
Author: Guillaume Thouvenin <email address hidden>
Date: Tue Aug 9 11:59:41 2016 +0200

    Fix issue with LDAP protocol radio button

    This patch modifies the label of the radio button used for selecting
    the LDAP protocol to make it unique across all the StackLight plugins.

    Change-Id: I3e2de2c59bc46594293cfd902098b9ae7292869b
    Partial-Bug: #1599778

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352817
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-lma-infrastructure-alerting/commit/?id=57e43e3a0a64b6e805169ead4493aafee285871b
Submitter: Jenkins
Branch: master

commit 57e43e3a0a64b6e805169ead4493aafee285871b
Author: Guillaume Thouvenin <email address hidden>
Date: Tue Aug 9 11:51:40 2016 +0200

    Fix issue with LDAP protocol radio button

    This patch modifies the label of the radio button used for selecting
    the LDAP protocol to make it unique across all the StackLight plugins.

    Change-Id: I9fff175af82a5e6bab8666fa5f8c8f1b64926b0c
    Partial-Bug: #1599778

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352819
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-influxdb-grafana/commit/?id=3f5b22c2212924c1b28e260c6b64534becfcd5bd
Submitter: Jenkins
Branch: master

commit 3f5b22c2212924c1b28e260c6b64534becfcd5bd
Author: Guillaume Thouvenin <email address hidden>
Date: Tue Aug 9 12:02:21 2016 +0200

    Fix issue with LDAP protocol radio button

    This patch modifies the label of the radio button used for selecting
    the LDAP protocol to make it unique across all the StackLight plugins.

    Change-Id: Iafe43b4d0fc0b4b72bbf43e88575018618c750c8
    Partial-Bug: #1599778

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/0.10
Review: https://review.openstack.org/353598

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/0.10
Review: https://review.openstack.org/353599

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/0.10
Review: https://review.openstack.org/353601

[Simon Pasquier (simon-pasquier)]

Note that it's only an UI issue. The LDAP settings are properly saved and applied when deploying the environment.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/353598
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-influxdb-grafana/commit/?id=6eb12ae190c86d95a88c2bb69cfb0c1ea3fdeb80
Submitter: Jenkins
Branch: stable/0.10

commit 6eb12ae190c86d95a88c2bb69cfb0c1ea3fdeb80
Author: Guillaume Thouvenin <email address hidden>
Date: Tue Aug 9 12:02:21 2016 +0200

    Fix issue with LDAP protocol radio button

    This patch modifies the label of the radio button used for selecting
    the LDAP protocol to make it unique across all the StackLight plugins.

    Change-Id: Iafe43b4d0fc0b4b72bbf43e88575018618c750c8
    Partial-Bug: #1599778
    (cherry picked from commit 3f5b22c2212924c1b28e260c6b64534becfcd5bd)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/353599
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-elasticsearch-kibana/commit/?id=d7a4360c7fec1ad4bf771ab12fb0eb77a059c444
Submitter: Jenkins
Branch: stable/0.10

commit d7a4360c7fec1ad4bf771ab12fb0eb77a059c444
Author: Guillaume Thouvenin <email address hidden>
Date: Tue Aug 9 11:59:41 2016 +0200

    Fix issue with LDAP protocol radio button

    This patch modifies the label of the radio button used for selecting
    the LDAP protocol to make it unique across all the StackLight plugins.

    Change-Id: I3e2de2c59bc46594293cfd902098b9ae7292869b
    Partial-Bug: #1599778
    (cherry picked from commit 459a7f272390f48114cc03377ce98add1154371c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/353601
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-lma-infrastructure-alerting/commit/?id=e02a272b9dd47c22fb1b61652780bba4e7badbb5
Submitter: Jenkins
Branch: stable/0.10

commit e02a272b9dd47c22fb1b61652780bba4e7badbb5
Author: Guillaume Thouvenin <email address hidden>
Date: Tue Aug 9 11:51:40 2016 +0200

    Fix issue with LDAP protocol radio button

    This patch modifies the label of the radio button used for selecting
    the LDAP protocol to make it unique across all the StackLight plugins.

    Change-Id: I9fff175af82a5e6bab8666fa5f8c8f1b64926b0c
    Partial-Bug: #1599778
    (cherry picked from commit 57e43e3a0a64b6e805169ead4493aafee285871b)