The LMA collector services get restarted after re-executing the setup_repositories task

[Simon Pasquier]

Tested on stable/0.9 with MOS 8.

Steps to reproduce
------------------

1. Deploy one environment with the LMA plugins.
2. Store the PIDs of collectd and lma_collector services for all nodes.
3. Re-execute the setup_repositories task
$ fuel node -env <ENV_ID> node --node-id <NODE_ID1> <NODE_ID2> <NODE_ID_N> --tasks setup_repositories
4. Check the PIDs of collectd and lma_collector services for all nodes.

Expected result
---------------

The PIDs haven't changed.

Actual result
-------------

The PIDs have changed.

[Simon Pasquier (simon-pasquier)]

The core of the issue is that Fuel always runs the post_deployment task even though the operator asked for the re-execution of only one task.

Regarding lma_collector, the problem is in the heka Puppet module [1]. It tries to stop heka running /etc/init.d/heka which will kill any process named hekad.

Regarding collectd, it is more tricky: the lma_collector/base.pp manifest wipes out the conf.d directory to get rid of the default configuration and the other manifests (controller.pp, compute.pp, ...) add on top of that.

[1] https://github.com/openstack/fuel-plugin-lma-collector/blob/96df47af7385578280a68863b55416da7dd8bfdb/deployment_scripts/puppet/modules/heka/manifests/init.pp#L111

[Simon Pasquier (simon-pasquier)]

I've filed a bug [1] in Fuel to highlight the re-execution of post_deployment tasks.

[1] https://bugs.launchpad.net/fuel/+bug/1570880

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/307319

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/307319
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-lma-collector/commit/?id=a8162054ba717df6a1a6315e65ecf13aa1060824
Submitter: Jenkins
Branch: master

commit a8162054ba717df6a1a6315e65ecf13aa1060824
Author: Simon Pasquier <email address hidden>
Date: Mon Apr 18 17:12:26 2016 +0200

    Add note about task re-execution

    Change-Id: I51eb6368dbbf7f8ef6edb9768da9c46fca47a3ee
    Related-Bug: #1570850

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/0.9
Review: https://review.openstack.org/308827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308827
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-lma-collector/commit/?id=e7102cab582f55fcf372f123213f39e0da8f2ca7
Submitter: Jenkins
Branch: stable/0.9

commit e7102cab582f55fcf372f123213f39e0da8f2ca7
Author: Simon Pasquier <email address hidden>
Date: Mon Apr 18 17:12:26 2016 +0200

    Add note about task re-execution

    Change-Id: I51eb6368dbbf7f8ef6edb9768da9c46fca47a3ee
    Related-Bug: #1570850
    (cherry picked from commit a8162054ba717df6a1a6315e65ecf13aa1060824)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/311767

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311767
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-lma-collector/commit/?id=89882ae849423016bd454e1882185b7af7b8d1f4
Submitter: Jenkins
Branch: master

commit 89882ae849423016bd454e1882185b7af7b8d1f4
Author: Swann Croiset <email address hidden>
Date: Mon May 2 17:41:14 2016 +0200

    Remove the init script shipped by the heka package

    This prevents to restart all collectors by side effect when
    '/etc/init.d/heka stop' is run.

    Change-Id: I4f743e765e5895f3c97505a166140bcd80f7ce34
    Partial-bug: #1570850