Nailgun allows duplicate links from plugins

[Vitaly Kramskikh]

Nailgun allows duplicate links from plugins, which may appear after rerunning puppet manifests. I think nailgun should prohibit duplicate links using their url and title as a key.

[Ilya Kutukov (ikutukov)]

I think it will not be good to raise an error response because that could break plugin work.

So i purpose to make record update when POST contain plugin URL that is already persist in plugins table.

But this approach violates REST.

[Vitaly Kramskikh (vkramskikh)]

I think we should explicitly document that this handler will return 409 in case of duplicate link and that's a normal situation that should be handled by plugin. It should be a pretty common situation for puppet-based plugins.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/273648

[Ihor Kalnytskyi (ikalnytskyi)]

That's not a high according to OpenStack Triage process. The case isn't destructive.

[Ihor Kalnytskyi (ikalnytskyi)]

So I lower prio, and mark it as Won't Fixed.

[Vitaly Kramskikh (vkramskikh)]

Can we still fix it in 8.0? Whether this fix is merged will define how plugin authors will write their plugins. Duplicate links won't show up after initial testing, so I think if we don't merge this change to 8.0, we'll end up with many plugins providing duplicate links. Since there is no way to remove them, this could make Fuel Dashboard unusuable

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Dmitry Pyzhov (dpyzhov)]

We passed SCF for 9.0. Moving the medium priority bug to 10.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/273648
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=dcd4757e247816d3afc779be1c8ba076b39bc815
Submitter: Jenkins
Branch: master

commit dcd4757e247816d3afc779be1c8ba076b39bc815
Author: Ilya Kutukov <email address hidden>
Date: Thu Jan 28 19:49:06 2016 +0300

    Plugin links handlers now returning 409 on existing url

    Previous behaviour allowed to create multiple links with the same url
    what was occurring during plugin tasks re-run.

    Now 409 error is returned when plugin- or cluster-level link creating
    or updating with the non-unique URL value.
    Plugin developers should handle such exception by themselves
    in plugin tasks.

    DocImpact
    Closes-Bug: #1538209

    Change-Id: I1de1e9f3957cbe11e91cd8cd4806ac1cd714d630

[Swann Croiset (swann-w)]

The patch [0] is not shipped with mos-9.0 (not in stable/mitaka branch)
We'll try to leverage API new behavior in the next release.

[0] https://review.openstack.org/273648

[Rene Soto (rsoto)]

We received a report from a customer today that they are experiencing this same issue. There are two links for all services, except for Horizon.

Steps customer took to produce this issue:
1. Create cloud and deploy
2. Reset the environment
3. Change management network from 192.168.0.0/24 to 10.20.101.0/24 and deploy again

This results in two links: one with 192.168.0.x address and one with 10.20.101.x address (same for other services except horizon)

[Rudy McComb (rmccomb)]

I observed this behavior in another customers MOS 9.0 environment. There are 4 Kibana links in Fuel Dashboard all with 192.1.168.0.x, this is after 2 LMA related installs and only one link works.