mintBackup.py still not fully compliant with python-apt-0.8.0

Bug #829743 reported by Mike T
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Linux Mint
Fix Released
Undecided
Unassigned

Bug Description

guess i missed some things... see http://forums.linuxmint.com/viewtopic.php?f=33&t=78853&p=462853#p462853

working on a patch now.

Mike T (trustdarkness)
Changed in linuxmint:
assignee: nobody → M Thompson (hozomean)
status: New → In Progress
Revision history for this message
Mike T (trustdarkness) wrote :

/usr/share/python-apt/migrate-0.8.py -c /usr/lib/linuxmint/mintBackup/mintBackup.py
migrate-0.8.py - Find all occurences of funcs./attrs. deprecated in 0.8.

Information: Please verify that the results are correct before you modify any
code, because there may be false positives.

Information: The color is not always correct, because we simply highlight the
matched words (like grep).

/usr/lib/linuxmint/mintBackup/mintBackup.py:554: self.description = self.wTree.get_widget("entry_desc").get_text()
/usr/lib/linuxmint/mintBackup/mintBackup.py:559: if (self.description != ""):
/usr/lib/linuxmint/mintBackup/mintBackup.py:560: model.append(["<b>" + _("Description") + "</b>", self.description])
/usr/lib/linuxmint/mintBackup/mintBackup.py:678: self.description = "mintBackup"
/usr/lib/linuxmint/mintBackup/mintBackup.py:681: self.description = desc
/usr/lib/linuxmint/mintBackup/mintBackup.py:688: "description: %s\n" % (self.description) ]
/usr/lib/linuxmint/mintBackup/mintBackup.py:1091: self.conf.description = _("(Not created with the Backup Tool)")
/usr/lib/linuxmint/mintBackup/mintBackup.py:1099: self.wTree.get_widget("label_overview_description_value").set_label(self.conf.description)
/usr/lib/linuxmint/mintBackup/mintBackup.py:1115: self.conf.description = _("(Not created with the Backup Tool)")
/usr/lib/linuxmint/mintBackup/mintBackup.py:1121: self.wTree.get_widget("label_overview_description_value").set_label(self.conf.description)
/usr/lib/linuxmint/mintBackup/mintBackup.py:1433: desc = "<big>" + pkg.name + "</big>\n<small>" + pkg.installed.summary.replace("&", "&amp;") + "</small>"
/usr/lib/linuxmint/mintBackup/mintBackup.py:1587: if(cache.has_key(line)):
/usr/lib/linuxmint/mintBackup/mintBackup.py:1589: if(not pkg.isInstalled):
/usr/lib/linuxmint/mintBackup/mintBackup.py:1590: desc = pkg.candidate.summary.replace("&", "&amp;")

Though the "self.decription" calls here are all descendants of the mintBackup class, so don't apply, and according to the API reference, http://apt.alioth.debian.org/python-apt-doc/library/apt.cache.html, cache.has_key() is still relevant within this scope.

I'll be submitting a patch for the other proglems shortly. Sorry for not catching this the first time around.

Changed in linuxmint:
assignee: M Thompson (hozomean) → nobody
status: In Progress → New
Revision history for this message
Mike T (trustdarkness) wrote :

patch attatched. note the above reference to line 1433 from the migration script was not changed. The api reference on pthon-apt's site is a little lacking, IMHO, however, i looked at the code and Package.installed returns a Version() object, which does have a summary attribute. I've tested saving/restoring packages and all is well.

Reset status to New/Unassigned so someone from the mint team proper will pick it up. Not sure what proper etiquette is here, but if I should be doing something else in a case like this, please let me know. Many thanks.

Revision history for this message
Mike T (trustdarkness) wrote :

proper file name

Changed in linuxmint:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.