© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Correct me if I'm wrong, but with your patch the behavior between linuxdcpp and dc++ will differ. DC++ has the following:
%[file] = %[fileFN] = path + filename
So DC++ has only one variable to hold both pathname and filename. While your patch will separate path and filename into separate variables:
%[file] = %[fileFN] = filename
%[filepath] = %[filePH] = path
DC++ doesn't seem to have %[filePH] and %[filepath] or any other variable to hold just the path. Of course, the current behavior in linuxdcpp is wrong since it only contains the filename, but shouldn't we fix that by adding the path to %[file] and %[fileFN] instead of creating new variables? Are these other variables common in other clients is that why you included them?