Support Ubuntu application indicators

Bug #577327 reported by Maia Everett
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LinuxDC++
Undecided
Unassigned

Bug Description

I have committed a patch to Ubuntu Maverick (1.0.3-1ubuntu1) that replaces the tray icon with an application indicator icon. You are welcome to review and integrate it (perhaps falling back to the traditional GtkStatusIcon if libappindicator is not available).

Revision history for this message
Razzloss (razzloss) wrote :

Can you give a link to the patch or upload it here?

--RZ

Revision history for this message
Maia Everett (linneris) wrote :

Here is the patch.

Note that the indicator here removes existing GtkStatusIcon support - this is okay for Ubuntu because we know we're building with libappindicator, and it draws a fallback status icon if there is no indicator applet. For upstream, it should presumably be #ifdef'd.

Revision history for this message
Razzloss (razzloss) wrote :

Steven: Your opinion? I already ported the patch to trunk. With a total of 6 #ifs (2 of them in .hh) (and a broken notification support). If notification is fixed, should this be added?

Changed in linuxdcpp:
assignee: nobody → Razzloss (razzloss)
Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

I am against it. It looks like an Ubuntu specific library that duplicates most of the functionality already contained within GTK+ and doesn't even seem to be something that Gnome developers are interested in using for Gnome Shell in 3.0. Per GKT+ devs, it sounds like they aren't too keen on it:

http://<email address hidden>/msg18063.html

In addition, it is an unstable library in which its APIs can change at any time per its own documentation:

http://people.canonical.com/~ted/libappindicator/current/AppIndicator.html

For the above reasons and due to the fact that it would require hacks in our code to implement, I think it should stay as an Ubuntu specific patch. What are your thoughts RZ?

Revision history for this message
Razzloss (razzloss) wrote :

Oh, ok. I assumed it was something included in the new gnome, but if it's just an Ubuntu solo project we don't need this. I just hope that the patched version doesn't cause any problems, since the bugs are likely reported here...

--RZ

Changed in linuxdcpp:
assignee: Razzloss (razzloss) → nobody
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers