Enqueue magnet URIs directly to the download queue

Bug #546227 reported by lagalopex on 2010-03-24
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LinuxDC++
Wishlist
Razzloss

Bug Description

It's nice to have the ability to add a download via magnet-link. (Not just search for TTH.)

This patch adds a "directaddmagnet"-command for the linuxdcpp.pipe. Its only argument is a magnet-link.
If any informations is missing, it will just search for the TTH.

lagalopex (lagalopex) wrote :
Razzloss (razzloss) wrote :

QueueManager -functions shouldn't be called from the GUI threads. Since there's a possibility it will deadlock the client. (e.g. have tried adding few magnets to queue with dl queue open? Not saying it will deadlock, but might...)

So those QueueManager calls should be put in to their own _client -function and the call to that should be dispatched in the onExternalData callback.

Checked ApexDC++s magnet handling and they seemed to pass just UserPtr() instead of a dummy user, but that was with newer core (and what I tested, I wasn't able to get it to work with 0.75)

--RZ

Changed in linuxdcpp:
importance: Undecided → Wishlist
status: New → Confirmed
lagalopex (lagalopex) wrote :

Yes, I already added some magnet-links (automatically by javascript...)
It did not deadlock, but when there is a race I'll do it as expected.

Razzloss (razzloss) wrote :

Commited slightly modified version of the patch.

--RZ

Changed in linuxdcpp:
assignee: nobody → Razzloss (razzloss)
milestone: none → 1.1.0
status: Confirmed → Fix Committed
tags: added: command-line download-queue magnet
summary: - [WISH with PATCH]: possibility to enqueue a magnet-link directly on the
- download-queue
+ Enqueue magnet URIs directly to the download queue
Changed in linuxdcpp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers