Repeated password dialogs if dialog open while reconnecting

[Olorin]

There shows a pwd request window if it needed. But It accumulates. 10, 20, 30.... 100 pwd windows stores in the memory and then shows one by one. Then on some of that windows all interface freezes and program gives no responce.
Confurmation is strongly needed for this bug. I don't know, why LDC does... no any ideas.

[Steven Sheehy (steven-sheehy)]

screenshot please and steps to reproduce.

[Olorin (vivliofika)]

no screens needed... I see only one request a time. GUI dialog as usual.

1) start the LDCPP
2) leave it
3) a hub request the password, don't enter it, just leave
4) the hub drops, reconnects and requests the password again and again
5) then try to input the password

[Razzloss (razzloss)]

Seems to happen as described.

Hub::getPassword_gui() blocks as long as either OK or Cancel is clicked. If hub disconnects the user during this function and client reconnects another getPassword_gui call is added to the gui queue. This loop continues until user is there to acknowledge (all) the dialog.

getPassword_gui should be changed so that it doesn't use gtk_dialog_run and if the hub disconnects while the dialog is visible it should be hidden. Also hub name should be added to the password dialog since with not using gtk_dialog_run it will be possible that multiple password prompts are open at one time from different hubs. (It might be a bit difficult identify the hub asking for password even with current implementation if there's more than 1 hub open).

Patches are welcome...

--RZ