Downloading directory from search tab doesn't work anymore

Bug #432579 reported by Razzloss on 2009-09-18
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
LinuxDC++
Medium
Razzloss

Bug Description

Selecting a directory result in a search tab and double-clicking/menu->Download only downloads the filelist. Files within the directory aren't downloaded anymore. However selecting a file under that same directory and from context menu Download whole directory produces the correct result.

Related branches

Razzloss (razzloss) on 2009-09-18
Changed in linuxdcpp:
assignee: nobody → Razzloss (razzloss)
Razzloss (razzloss) wrote :

OK, Changed the path component in search results not to include the directory itself for directory type of results. IMO this makes much more sense (and I guess it used to be that way before?)

eg. for results, path is
A\B\ -> A\
A\B\a -> A\B\
A\B\b -> A\B\

But selecting Download Whole directory from A\B\ -result still downloads the contents of B\ not the whole A\. Is this the expected behavior or should the whole A\ be downloaded?

--RZ

Changed in linuxdcpp:
status: Confirmed → Fix Committed
Steven Sheehy (steven-sheehy) wrote :

I think it should behave as it does and download A\B\. In the case of directory search results, download and download whole dir should do the same thing. Now if we changed the wording to "Download parent directory" or "Download containing directory", we would download A\. Or perhaps we should remove/gray out download whole dir for directory results to reduce confusion?

Razzloss (razzloss) wrote :

Path needs to be set to "" when directory is directly under root. Currently downloading these 1st level directories doesn't work, as path is non-empty (eg. for A\, path would be A, and resulting download command is AA\). I'll commit the fix later.

--RZ

Changed in linuxdcpp:
status: Fix Committed → In Progress
Razzloss (razzloss) on 2009-10-14
Changed in linuxdcpp:
status: In Progress → Fix Committed
Changed in linuxdcpp:
status: Fix Committed → Fix Released
tags: added: ui
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers