Comment 19 for bug 406302

Revision history for this message
Razzloss (razzloss) wrote :

Steven: My thoughts exactly when I read lys' opinion. I think #IFDEFfing the contents of showNotify, #include and the settingsmanager options should be enough? Defaults still need to be there, and maybe defaulting to 0 (or default based on #IFDEF)? I think this would be neater than #IFDEFing all the calls to showNotification and it's contents (sure adds few unneeded function calls if defaults are 1, but won't affect performance).

With #IFDEFs Gentoo ebuilds can set the use flags correctly which will pull libnotify and its dependencies when needed.

--RZ