LinuxDC++

  1. Bug #406302
  2. Comment #10

Comment 10 for bug 406302

Revision history for this message
Razzloss (razzloss) wrote :

OK,

Few comments:
1) Do we really need a new class with just one static method? IMO notification showing could as well be put to MainWindow as a member function.
2) In Notification::show the icon path must not be hardcoded. Icon path should be derived from WulforManager::getPath() or if possible from the current icon theme. (I'm not too clear on how IconThemes work so it might not be possible)

--RZ