Comment 13 for bug 271565

Steven Sheehy (steven-sheehy) wrote :

Thanks for the patch, it's good to have you back :). A few things:

- UCparam should be UCParam and UCParams should be ucParams.
- Please make filesize an int64_t, no need to store it as a string since it will have to be converted to an int64_t for formatting later anyway.
- Please implement "type" variable as well. You can do it dynamically based upon filename having PATH_SEPARATOR.
- Populate the params differently depending on whether it's a file or a directory (see DirectoryListingFrame::runUserCommand)
- What about user commands in directory view of sharebrowser?