.desktop file that do not pass validation

Bug #1063970 reported by Pim Vullers
22
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Cerbere
Won't Fix
Low
Unassigned
Files
Won't Fix
Low
Unassigned
Lingo
Won't Fix
Undecided
Unassigned
Maya
Won't Fix
Low
Unassigned
Plank
Invalid
Low
Robert Dyer
Scratch
Fix Released
Medium
Cody Garver
Switchboard
Fix Released
Medium
Unassigned
Terminal
Won't Fix
Low
Unassigned
Wingpanel
Fix Released
Medium
Unassigned

Bug Description

When installing Cerbere on Gentoo I get the following notice:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/cerbere.desktop: error: value "Pantheon" for string list key "OnlyShowIn" in group "Desktop Entry" does not have a semicolon (';') as trailing character
 /usr/share/applications/cerbere.desktop: error: value "System" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Related branches

Revision history for this message
Pim Vullers (pimvullers) wrote :

When applying the fix from the linked branch I get another notice:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/cerbere.desktop: error: value "Pantheon;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Pantheon"; values extending the format should start with "X-"

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for wingpanel:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/wingpanel.desktop: error: value "Utility" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for Dropoff:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/dropoff.desktop: error: (will be fatal in the future): value "application/*;audio/*;example/*;image/*;message/*;model/*;multipart/*;text/*;video/*;" for key "MimeType" in group "Desktop Entry" contains value "example/*" which is an invalid MIME type: "example" is a media type that must not be used
/usr/share/applications/dropoff.desktop: warning: value "application/*;audio/*;example/*;image/*;message/*;model/*;multipart/*;text/*;video/*;" for key "MimeType" in group "Desktop Entry" contains value "message/*" which is a MIME type that should probably not be used: "message" is a media type that probably does not make sense in this context
/usr/share/applications/dropoff.desktop: warning: value "application/*;audio/*;example/*;image/*;message/*;model/*;multipart/*;text/*;video/*;" for key "MimeType" in group "Desktop Entry" contains value "multipart/*" which is a MIME type that should probably not be used: "multipart" is a media type that probably does not make sense in this context

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for pantheon-terminal:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/pantheon-terminal.desktop: error: (will be fatal in the future): value "TerminalEmulator" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: System
/usr/share/applications/pantheon-terminal.desktop: error: file contains group "NewRootWindow Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/pantheon-terminal.desktop: error: file contains group "NewWindow Shortcut Group", but groups extending the format should start with "X-"

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for switchboard:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/switchboard.desktop: error: (will be fatal in the future): value "GTK;Administration;" for key "Categories" in group "Desktop Entry" does not contain a registered main category
/usr/share/applications/switchboard.desktop: error: value "0.8" for key "Version" in group "Desktop Entry" is not a known version
/usr/share/applications/switchboard.desktop: error: value "GTK;Administration;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Administration"; values extending the format should start with "X-"

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for plank:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/plank.desktop: error: value "Pantheon;" for key "NotShowIn" in group "Desktop Entry" contains an unregistered value "Pantheon"; values extending the format should start with "X-"

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for lingo:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/lingo.desktop: error: file contains key "_Comment" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
/usr/share/applications/lingo.desktop: error: file contains key "_GenericName" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
/usr/share/applications/lingo.desktop: error: value "0.8" for key "Version" in group "Desktop Entry" is not a known version

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for pantheon-files:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/pantheon-files.desktop: error: file contains group "Root Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/pantheon-files.desktop: error: file contains group "TabNew Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/pantheon-files.desktop: error: file contains group "WindowNew Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/pantheon-files.desktop: warning: value "x-directory/gnome-default-handler;x-directory/normal;inode/directory;" for key "MimeType" in group "Desktop Entry" contains value "x-directory/gnome-default-handler" which is a MIME type that should probably not be used: "x-directory" is an old media type that should be replaced with a modern equivalent
/usr/share/applications/pantheon-files.desktop: warning: value "x-directory/gnome-default-handler;x-directory/normal;inode/directory;" for key "MimeType" in group "Desktop Entry" contains value "x-directory/normal" which is a MIME type that should probably not be used: "x-directory" is an old media type that should be replaced with a modern equivalent

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also holds for scratch:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/scratch-text-editor.desktop: error: file contains group "NewDocument Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/scratch-text-editor.desktop: error: file contains group "NewWindow Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/scratch-text-editor.desktop: error: file contains multiple keys named "MimeType" in group "Desktop Entry"
/usr/share/applications/scratch-text-editor.desktop: error: value "1.1" for key "Version" in group "Desktop Entry" is not a known version

Revision history for this message
Robert Dyer (psybers) wrote :

Plank fixes this in rev 690. Note that Plank fixed it by REMOVING 'NotShowIn' as this is not relevant directly to Plank (Plank is NOT an elementary project).

Changed in plank:
status: New → Fix Released
importance: Undecided → Low
assignee: nobody → Robert Dyer (psybers)
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@robert: Please stop this madness and acknowledge the fact elementary is using plank and we should support this!

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@pimvullers: There is nothing wrong with plank.desktop. Do you actually have "pantheon.session" installed while running your tests?

Changed in plank:
status: Fix Released → Incomplete
Revision history for this message
Pim Vullers (pimvullers) wrote :

@ricotz: I do have this file installed in /usr/share/gnome-session/sessions. I don't know, however, which application does this validation. (I guess it's the Gentoo package manager calling some XDG tool.) It might be that this tool does not look in the right places. If anybody has any ideas? I'll try to look into this.

Revision history for this message
Pim Vullers (pimvullers) wrote :

I discovered the tool that validates these files: desktop-file-validate
I also checked the freedektop.org specification for .desktop files. According to it, the only valid environments are listed in: http://standards.freedesktop.org/menu-spec/latest/apb.html, @ricotz: I see no reference to .session files adding items to this list.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@pimvullers: OK, then you need to ignore that "Pantheon" isn't recognized.
So someone should look into how "Pantheon" can be added there to make it official.

Changed in plank:
status: Incomplete → Invalid
Revision history for this message
Robert Dyer (psybers) wrote :

No, according to the specification the correct solution is to put 'X-Pantheon' there. Unless you manage to change the spec itself. And no, Plank does not directly support any specific window manager or DE. IF a specific DE has a problem with our packages, they are welcome to package it themselves.

Revision history for this message
Pim Vullers (pimvullers) wrote :

This also affects maya:

QA Notice: This package installs one or more .desktop files that do not pass validation.

/usr/share/applications/maya.desktop: error: file contains group "AddEvent Shortcut Group", but groups extending the format should start with "X-"
/usr/share/applications/maya.desktop: error: value "text/calendar" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Revision history for this message
David Gomes (davidgomes) wrote :

This bug has been half-fixed on the Terminal.

Changed in pantheon-terminal:
importance: Undecided → Low
milestone: none → luna-beta2
status: New → Confirmed
status: Confirmed → Won't Fix
Cody Garver (codygarver)
Changed in switchboard:
importance: Undecided → Medium
status: New → Fix Released
Cody Garver (codygarver)
Changed in wingpanel:
importance: Undecided → Medium
status: New → Fix Released
Changed in maya:
status: New → Confirmed
milestone: none → luna-beta2
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

This is no way critical for betas IMO.
Our .desktop files work, so I'd mark it technical debt and clean this up after Luna release.

David Gomes (davidgomes)
Changed in maya:
importance: Undecided → Low
Changed in scratch:
assignee: nobody → Cody Garver (codygarver)
importance: Undecided → Medium
status: New → Confirmed
milestone: none → 1.2
status: Confirmed → Fix Committed
Changed in pantheon-terminal:
milestone: luna-beta2 → none
Revision history for this message
Cody Garver (codygarver) wrote :

The desktop validator tool does not understand dock quicklists.

Changed in maya:
milestone: luna-beta2 → none
status: Confirmed → Won't Fix
Revision history for this message
Victor Martinez (victored) wrote :

Fixing this on Cerbere broke the session manager client, so let's delay the fix until we upgrade to a more recent system.

Changed in cerbere:
assignee: nobody → Victor Eduardo (victored)
importance: Undecided → Low
milestone: none → 0.2
status: New → Fix Committed
milestone: 0.2 → none
status: Fix Committed → Triaged
assignee: Victor Eduardo (victored) → nobody
Changed in pantheon-files:
importance: Undecided → Low
status: New → Triaged
Changed in scratch:
status: Fix Committed → Fix Released
Changed in scratch:
status: Fix Released → Fix Committed
Revision history for this message
Cody Garver (codygarver) wrote :

"We're making things that work, not things that are theoretically kosher." --shnatsel

Changed in pantheon-files:
status: Triaged → Won't Fix
Revision history for this message
Robert Dyer (psybers) wrote :

"I make things that work *and* are kosher." --PsyberS

Revision history for this message
Cody Garver (codygarver) wrote : Re: [Bug 1063970] Re: .desktop file that do not pass validation

You Invalid/Won't Fixed this bug too IIRC..

Sent from my iPhone

On Dec 26, 2012, at 8:20 AM, Robert Dyer <email address hidden> wrote:

> "I make things that work *and* are kosher." --PsyberS
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1063970
>
> Title:
> .desktop file that do not pass validation
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cerbere/+bug/1063970/+subscriptions

Cody Garver (codygarver)
Changed in scratch:
status: Fix Committed → Fix Released
Changed in lingo-dictionary:
status: New → Won't Fix
no longer affects: dropoff
Changed in cerbere:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.