webkit needs porting

Bug #1096053 reported by Marcin Juszkiewicz on 2013-01-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro AArch64 cross-distro work
Medium
Riku Voipio
Linaro OpenEmbedded
Fix Released
Undecided
Unassigned

Bug Description

In file included from ./Source/JavaScriptCore/wtf/FastAllocBase.h:93:0,
                 from ./Source/JavaScriptCore/wtf/RefPtr.h:27,
                 from ./Source/JavaScriptCore/wtf/HashFunctions.h:24,
                 from ./Source/JavaScriptCore/wtf/HashTraits.h:24,
                 from ./Source/JavaScriptCore/wtf/HashTable.h:28,
                 from ./Source/JavaScriptCore/wtf/HashMap.h:24,
                 from ./Source/JavaScriptCore/runtime/JSValue.h:31,
                 from ./Source/JavaScriptCore/runtime/CallData.h:32,
                 from ./Source/JavaScriptCore/runtime/JSCell.h:26,
                 from ./Source/JavaScriptCore/runtime/JSAPIValueWrapper.h:26,
                 from Source/JavaScriptCore/API/APICast.h:29,
                 from Source/JavaScriptCore/API/JSValueRef.cpp:29:
./Source/JavaScriptCore/wtf/StdLibExtras.h: In instantiation of 'TO WTF::bitwise_cast(FROM) [with TO = JSC::JSCell*; FROM = int]':
./Source/JavaScriptCore/interpreter/Register.h:196:47: required from here
./Source/JavaScriptCore/wtf/StdLibExtras.h:123:1: error: size of array is negative
make[1]: *** [Source/JavaScriptCore/API/libjavascriptcoregtk_1_0_la-JSValueRef.lo] Error 1
make[1]: *** [Source/JavaScriptCore/API/libjavascriptcoregtk_1_0_la-JSCallbackFunction.lo] Error 1
make[1]: *** [Source/JavaScriptCore/API/libjavascriptcoregtk_1_0_la-JSObjectRef.lo] Error 1

Riku Voipio (riku-voipio) wrote :

Basic AARCH64 defines for webkit-1.8.2

Of course, the really proper support would involve writing a JIT. But perhaps we are more interested in writing a V8 JIT.

Changed in linaro-aarch64:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Riku Voipio (riku-voipio)
Changed in linaro-oe:
status: New → Fix Committed
Riku Voipio (riku-voipio) wrote :
Download full text (4.4 KiB)

Testsuite results:

-snip-
./run-gtk-tests-nogir
Could not start accessibility bus, so skipping TestWebKitAccessibility
Skipping ../../WebKitBuild/Programs/unittests/testwebview
Skipping ../../WebKitBuild/Programs/unittests/testwebresource
Skipping ../../WebKitBuild/Programs/unittests/testdownload
TEST: ../../WebKitBuild/Programs/unittests/testfavicondatabase... (pid=303)
PASS: ../../WebKitBuild/Programs/unittests/testfavicondatabase
TEST: ../../WebKitBuild/Programs/unittests/testdomdocument... (pid=311)
PASS: ../../WebKitBuild/Programs/unittests/testdomdocument
TEST: ../../WebKitBuild/Programs/unittests/testhittestresult... (pid=317)
../../WebKitBuild/Programs/unittests/testhittestresult: line 117: /data/oe/build/tmp-eglibc/work/aarch64-oe-linux/webkit-gtk/1.8.2-r3/webkit-1.8.2/WebKitBuild/Programs/unittests/.libs/lt-testhittestresult: Success
PASS: ../../WebKitBuild/Programs/unittests/testhittestresult
TEST: ../../WebKitBuild/Programs/unittests/testglobals... (pid=335)
PASS: ../../WebKitBuild/Programs/unittests/testglobals
TEST: ../../WebKitBuild/Programs/unittests/testdomdomwindow... (pid=340)
PASS: ../../WebKitBuild/Programs/unittests/testdomdomwindow
TEST: ../../WebKitBuild/Programs/unittests/testwebhistoryitem... (pid=346)
PASS: ../../WebKitBuild/Programs/unittests/testwebhistoryitem
TEST: ../../WebKitBuild/Programs/unittests/testwebbackforwardlist... (pid=351)
PASS: ../../WebKitBuild/Programs/unittests/testwebbackforwardlist
TEST: ../../WebKitBuild/Programs/unittests/testnetworkrequest... (pid=356)
PASS: ../../WebKitBuild/Programs/unittests/testnetworkrequest
TEST: ../../WebKitBuild/Programs/unittests/testatkroles... (pid=361)
PASS: ../../WebKitBuild/Programs/unittests/testatkroles
TEST: ../../WebKitBuild/Programs/unittests/testwebsettings... (pid=367)
PASS: ../../WebKitBuild/Programs/unittests/testwebsettings
TEST: ../../WebKitBuild/Programs/unittests/testmimehandling... (pid=372)

(../../WebKitBuild/Programs/unittests/testmimehandling:372): libsoup-CRITICAL **: soup_message_io_pause: assertion `io->read_state < SOUP_MESSAGE_IO_STATE_BODY' failed
GTester: last random seed: R02S38b0baf80e9d5e49816711efc7736cd5
TEST: ../../WebKitBuild/Programs/unittests/testloading... (pid=379)
PASS: ../../WebKitBuild/Programs/unittests/testloading
TEST: ../../WebKitBuild/Programs/unittests/testwebinspector... (pid=386)
PASS: ../../WebKitBuild/Programs/unittests/testwebinspector
TEST: ../../WebKitBuild/Programs/unittests/testwebframe... (pid=424)
PASS: ../../WebKitBuild/Programs/unittests/testwebframe
TEST: ../../WebKitBuild/Programs/unittests/testkeyevents... (pid=430)

(../../WebKitBuild/Programs/unittests/testkeyevents:430): Gtk-WARNING **: Attempt to load unknown IM context type 'xim'
GTester: last random seed: R02S8d42b0d02cbe16b00e57110bae5da5e5
TEST: ../../WebKitBuild/Programs/unittests/testapplicationcache... (pid=436)
PASS: ../../WebKitBuild/Programs/unittests/testapplicationcache
TEST: ../../WebKitBuild/Programs/unittests/testwebplugindatabase... (pid=441)
PASS: ../../WebKitBuild/Programs/unittests/testwebplugindatabase
TEST: ../../WebKitBuild/Programs/unittests/testhttpbackend... (pid=446)
PASS: ../../WebKitBuild/Programs/unittests/testhttpb...

Read more...

Fathi Boudra (fboudra) on 2013-03-29
Changed in linaro-oe:
status: Fix Committed → Fix Released
Marcin Juszkiewicz (hrw) wrote :

Upstream webkit has AArch64 support now due to Apple A7 cpu used in iPhone 5S and some iPads.

But building for aarch64-gnu-linux fails due to __arm64__ != __aarch64__ definitions. After changing WTF/wtf/Platform.h to make use of __aarch64__ to set WTF_CPU_ARM64 it fails in lot of places:

/tmp/cckuPd0e.s:16393: Error: the optional immediate offset can only be 0 at operand 3 -- `stxr w3,w2,[x0,1048]'
/tmp/cckuPd0e.s:16574: Error: the optional immediate offset can only be 0 at operand 2 -- `ldxr w1,[x19,1048]'
/tmp/cckuPd0e.s:16577: Error: the optional immediate offset can only be 0 at operand 3 -- `stxr w0,w20,[x19,1048]'

I suspect LLVM/CLang != GCC stuff here.

Riku Voipio (riku-voipio) wrote :

This has since changed in WebKit and Blink. Since neither have traditional releases, we should tag this as fix released.

Changed in linaro-aarch64:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers