Leaks loop mounts on error
Bug #814256 reported by
James Westby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Linaro Image Tools |
Fix Released
|
Undecided
|
Guilherme Salgado |
Bug Description
In bug 813296 Dave reported that linaro-media-create was leaking loop mounts on error. We shouldn't do that.
Thanks,
James
Related branches
lp:~salgado/linaro-image-tools/bug-814256
- James Westby (community): Approve
-
Diff: 106 lines (+25/-13)2 files modifiedlinaro_image_tools/media_create/rootfs.py (+18/-11)
linaro_image_tools/media_create/tests/test_media_create.py (+7/-2)
Changed in linaro-image-tools: | |
assignee: | nobody → Guilherme Salgado (salgado) |
status: | New → In Progress |
Changed in linaro-image-tools: | |
status: | In Progress → Fix Committed |
Changed in linaro-image-tools: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Not sure if you want to track this here, or treat it as a new problem, but I tried todays image/hwpack (20110723) with the latest linaro-media-create and got it to leak loopback devs again. Here's the traceback:
Writing inode tables: done
Creating journal (16384 blocks): done
Writing superblocks and filesystem accounting information: done
This filesystem will be automatically checked every 26 mounts or /binary/ usr/lib/ u-boot/ omap4_panda/ u-boot. bin' -> `/tmp/tmpLRavw0 /boot-disc/ u-boot. bin' plars/work/ linaro/ linaro- image-tools/ linaro- media-create" , line 161, in <module> plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ media_create/ boards. py", line 483, in populate_boot or_file) plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ media_create/ boards. py", line 570, in make_boot_files set_appropriate _serial_ tty(chroot_ dir) plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ media_create/ boards. py", line 560, in set_appropriate _serial_ tty '.*2\.6\ .([0-9] {2}).*' , basename).group(1) _run_exitfuncs: python2. 7/atexit. py", line 24, in _run_exitfuncs plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ media_create/ partitions. py", line 234, in undo runner. run(['losetup' , '-d', device], as_root= True).wait( ) plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ cmd_runner. py", line 100, in wait roReturnValue( self._my_ args, returncode) roReturnValue: Sub process "['losetup', '-d', '/dev/loop0']" returned a non-zero value: 1 python2. 7/atexit. py", line 24, in _run_exitfuncs plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ media_create/ partitions. py", line 234, in undo runner. run(['losetup' , '-d', device], as_root= True).wait( ) plars/work/ linaro/ linaro- image-tools/ linaro_ image_tools/ cmd_runner. py", line 100, in wait roReturnValue( self._my_ args, returncode) image_tools. cmd_runner. SubcommandNonZe roReturnValue: Sub process "['losetup', '-d', '/dev/loop0']" returned a non-zero value: 1
180 days, whichever comes first. Use tune2fs -c or -i to override.
`/tmp/tmpLRavw0
Traceback (most recent call last):
File "/home/
args.is_live, args.is_lowmem, args.consoles)
File "/home/
rootfs_uuid, boot_disk, boot_device_
File "/home/
cls.
File "/home/
minor_version = re.match(
AttributeError: 'NoneType' object has no attribute 'group'
loop: can't delete device /dev/loop0: Device or resource busy
Error in atexit.
Traceback (most recent call last):
File "/usr/lib/
func(*targs, **kargs)
File "/home/
cmd_
File "/home/
raise SubcommandNonZe
SubcommandNonZe
Error in sys.exitfunc:
Traceback (most recent call last):
File "/usr/lib/
func(*targs, **kargs)
File "/home/
cmd_
File "/home/
raise SubcommandNonZe
linaro_